Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap top level ThemeProvider in CacheProvider #1717

Merged
merged 5 commits into from
May 5, 2021
Merged

Conversation

hasparus
Copy link
Member

@hasparus hasparus commented May 4, 2021

📦 Published PR as canary version: 0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0

✨ Test out this PR locally via:

npm install @theme-ui/color-modes@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/color@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/components@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/core@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/css@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/custom-properties@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/editor@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install gatsby-plugin-theme-ui@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install gatsby-theme-code-recipes@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install gatsby-theme-style-guide@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install gatsby-theme-ui-layout@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/match-media@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/mdx@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/parse-props@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-base@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-bootstrap@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-bulma@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-dark@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-deep@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-funk@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-future@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-polaris@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-roboto@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-sketchy@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-swiss@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-system@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-tailwind@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/preset-tosh@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/presets@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/prism@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/sidenav@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/style-guide@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/tachyons@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/tailwind@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/theme-provider@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install theme-ui@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
npm install @theme-ui/typography@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
# or 
yarn add @theme-ui/color-modes@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/color@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/components@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/core@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/css@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/custom-properties@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/editor@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add gatsby-plugin-theme-ui@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add gatsby-theme-code-recipes@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add gatsby-theme-style-guide@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add gatsby-theme-ui-layout@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/match-media@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/mdx@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/parse-props@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-base@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-bootstrap@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-bulma@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-dark@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-deep@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-funk@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-future@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-polaris@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-roboto@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-sketchy@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-swiss@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-system@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-tailwind@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/preset-tosh@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/presets@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/prism@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/sidenav@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/style-guide@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/tachyons@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/tailwind@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/theme-provider@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add theme-ui@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0
yarn add @theme-ui/typography@0.8.0--canary.1717.53f4d72b5c613588c36cd787d434c5767b4a7de7.0

@vercel
Copy link

vercel bot commented May 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/98L3nXZCAfkREuG4YmTmsMkSkWWd
✅ Preview: https://theme-ui-git-cache-provider-systemui.vercel.app

@hasparus hasparus merged commit fd992d2 into develop May 5, 2021
@hasparus hasparus deleted the cache-provider branch May 5, 2021 09:09
@hasparus hasparus added the released This issue/pull request has been released. label May 5, 2021
hasparus added a commit that referenced this pull request May 5, 2021
This reverts commit fd992d2, reversing
changes made to 24e40b7.
@hasparus
Copy link
Member Author

hasparus commented May 5, 2021

I'm reverting this change for v0.8.0 as it significantly complicates SSR setup (https://emotion.sh/docs/ssr#on-server) so it would require changes to gatsby-plugin-theme-ui, Next examples and thorough documentation.

@hasparus
Copy link
Member Author

hasparus commented May 5, 2021

🚀 PR was released in v0.8.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants