chore: More explicit Gatsby peer dep #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/9SyjwtchrRrxU8zw2kk9dP6vQDA6 |
|
On the CHANGELOG, I believe you can just add that heading to the top of the document. Thanks! |
|
Done 👍 |
|
Just FYI folks, you don't need to edit the changelog anymore. I've set up auto which should take care of this before release (and even if it breaks we can run |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello , Gatsby maintainer here 👋
While looking at the plugins I noticed that the
peerDependencyongatsbyis set incorrectly. In 55dab22 it was changed to>=2. We're in the process of providing more helpful information on the/pluginspage of our website and for that we need plugins to set theirpeerDependenciescorrectly/more specific.At the moment you say that any version (v3, v4, v5, v6, etc.) will work with this even when in between we'd introduce breaking changes.
Making it more explicit is the safer choice (in the future you'll be able to mark breaking changes with explicit version ranges) and will allow us to display the plugin as compatible to versions X, Y, Z.
Thanks!
P.S.: Please let me know where I should change the
CHANGELOG? I don't see aUNRELEASEDbulletpoint anymore :)