fix(theme-ui): export jsx as createElement #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the new JSX runtime, Babel will fall back to calling `createElement` (name not configurable) from the configured `jsxImportSource` when there is both an explicit `key` prop and object spread props. This causes a crash when using theme-ui since the custom JSX pragma is only exported as `jsx`. Reexport the `jsx` pragma under the name `createElement` to fix this.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/9fXgWjUmTojAoPYStt57JcZ94La2 |
|
Thanks for your PR! Going to leave this to @hasparus since I don't know much about this area. |
|
Thanks for the PR @ethanwu10! Good catch! |
|
@ethanwu10 This PR was released with I'll merge it to Here's your CodeSandbox with updated Theme UI — https://codesandbox.io/s/staging-surf-psxdy?file=/src/index.js. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1603
The new JSX runtime transformation will sometimes use the
createElementnamed export from thejsxImportSource, howevertheme-uidoes not export its pragma under this name, causing crashes. This PR reexports thejsxpragma under the namecreateElementto fix this. For reference,@emotion/reactcurrently does the same thingA minimal reproduction case is rendering any JSX element with both spread props and a
keyprop:(codesandbox)
As far as I can tell, the tests use the classic runtime, so there is no way to write a test for this other than explicitly doing
import { createElement } from 'theme-ui'and creating a node that way; is such a test worth having, since the use ofcreateElementis essentially an implementation detail of the JSX transform?📦 Published PR as canary version:
0.6.1-canary.1604.15f511c.0✨ Test out this PR locally via: