Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 add version information to the controller #28

Merged
merged 1 commit into from
Sep 28, 2023
Merged

🌱 add version information to the controller #28

merged 1 commit into from
Sep 28, 2023

Conversation

kranurag7
Copy link

@kranurag7 kranurag7 commented Sep 28, 2023 •
edited
Loading

this commit updates hack/version.sh to use the correct flags passed
during build time.

review

# create a new tag 
$ git tag v1.12.3
$ $ ./hack/version.sh
-X 'github.com/syself/hetzner-cloud-controller-manager/hcloud.providerVersion=v1.12.3'
# the above will be passed during the build process.

Signed-off-by: Anurag [email protected]

@kranurag7
add version information to the controller
0526aca 
this commit updates hack/version.sh to use the correct flags passed
during build time.

Signed-off-by: Anurag <[email protected]>
guettli
guettli approved these changes Sep 28, 2023
View reviewed changes
Copy link

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@guettli guettli merged commit 35dcd2f into syself:main Sep 28, 2023
@kranurag7 kranurag7 deleted the version-updates branch September 28, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guettli guettli guettli approved these changes

@batistein batistein Awaiting requested review from batistein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kranurag7 @guettli