-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typings #7
Merged
ChristianMurphy
merged 1 commit into
syntax-tree:master
from
ChristianMurphy:types/add-typescript-typings
Jul 30, 2019
Merged
Add typings #7
ChristianMurphy
merged 1 commit into
syntax-tree:master
from
ChristianMurphy:types/add-typescript-typings
Jul 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @Rokt33r |
ChristianMurphy
commented
Jul 30, 2019
Rokt33r
suggested changes
Jul 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could reuse the types. Others look awesome to me!
wooorm
approved these changes
Jul 30, 2019
8399e52
to
efe2f31
Compare
efe2f31
to
c0c0d55
Compare
wooorm
approved these changes
Jul 30, 2019
wooorm
pushed a commit
that referenced
this pull request
Jul 31, 2019
Related to: syntax-tree/unist-util-visit#16. Closes GH-7. Reviewed-by: Junyoung Choi <[email protected]> Reviewed-by: Titus Wormer <[email protected]>
ChristianMurphy
added a commit
to syntax-tree/unist-util-visit
that referenced
this pull request
Jul 31, 2019
related to: unifiedjs/unified#65 related to: syntax-tree/unist-util-visit-parents#7 resolves #15 * types: add typings and type tests for unist-util-visit * types: drop unused generic * test: add test for array of tests passed to visit * style: format type config files * types: leverage unist-util-is helpers * test: refactor examples to handle unknown type for node param * build: update dependency on unist-util-is to version 4 * types: leverage helper types from unist util visit parents, add actions * build: leverage stable unist-util-visit-parents 3.0.0 release
wooorm
pushed a commit
to syntax-tree/unist-util-visit
that referenced
this pull request
Jul 31, 2019
Related-to: unifiedjs/unified#65. Related-to: syntax-tree/unist-util-visit-parents#7. Closes GH-15. Reviewed-by: Junyoung Choi <[email protected]> Reviewed-by: Titus Wormer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
☂️ area/types
This affects typings
💪 phase/solved
Post is done
🧑 semver/major
This is a change
🦋 type/enhancement
This is great to have
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: syntax-tree/unist-util-visit#16