Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings #7

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy requested review from wooorm and a team July 30, 2019 03:47
@ChristianMurphy
Copy link
Member Author

/cc @Rokt33r

Copy link

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could reuse the types. Others look awesome to me!

@ChristianMurphy ChristianMurphy force-pushed the types/add-typescript-typings branch from 8399e52 to efe2f31 Compare July 30, 2019 15:38
@ChristianMurphy ChristianMurphy force-pushed the types/add-typescript-typings branch from efe2f31 to c0c0d55 Compare July 30, 2019 15:41
@ChristianMurphy ChristianMurphy merged commit 61d3786 into syntax-tree:master Jul 30, 2019
@ChristianMurphy ChristianMurphy deleted the types/add-typescript-typings branch July 30, 2019 16:25
wooorm pushed a commit that referenced this pull request Jul 31, 2019
Related to: syntax-tree/unist-util-visit#16.

Closes GH-7.

Reviewed-by: Junyoung Choi <[email protected]>
Reviewed-by: Titus Wormer <[email protected]>
ChristianMurphy added a commit to syntax-tree/unist-util-visit that referenced this pull request Jul 31, 2019
related to: unifiedjs/unified#65
related to: syntax-tree/unist-util-visit-parents#7
resolves #15

* types: add typings and type tests for unist-util-visit

* types: drop unused generic

* test: add test for array of tests passed to visit

* style: format type config files

* types: leverage unist-util-is helpers

* test: refactor examples to handle unknown type for node param

* build: update dependency on unist-util-is to version 4

* types: leverage helper types from unist util visit parents, add actions

* build: leverage stable unist-util-visit-parents 3.0.0 release
wooorm pushed a commit to syntax-tree/unist-util-visit that referenced this pull request Jul 31, 2019
Related-to: unifiedjs/unified#65.
Related-to: syntax-tree/unist-util-visit-parents#7.
Closes GH-15.

Reviewed-by: Junyoung Choi <[email protected]>
Reviewed-by: Titus Wormer <[email protected]>
@wooorm wooorm changed the title types: add typings for unist-util-visit-parents Add typings Aug 12, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants