Fix unquoted, tight, self-closing elements

remarkjs/remark-gfm#23
syntax-tree · Aug 31, 2021 · bb0238d · bb0238d
1 parent 62fa2f0
commit bb0238d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/lib/tree.js b/lib/tree.js
@@ -112,7 +112,7 @@ export function element(ctx, node, index, parent) {
       if (
         !ctx.tightClose ||
         last === '/' ||
-        (schema.space === 'svg' && last && last !== '"' && last !== "'")
+        (last && last !== '"' && last !== "'")
       ) {
         parts.push(' ')
       }

diff --git a/test/element.js b/test/element.js
@@ -35,15 +35,24 @@ test('`element`', (t) => {
     'should serialize voids with `/` in `closeSelfClosing` and `tightSelfClosing` mode'
   )
 
-  // This works in a browser.  The `/` is not part of the `[src]`.
+  t.deepEqual(
+    toHtml(h('input', {type: 'checkbox'}), {
+      preferUnquoted: true,
+      tightSelfClosing: true,
+      closeSelfClosing: true
+    }),
+    '<input type=checkbox />',
+    'should serialize voids with `/` in `closeSelfClosing` and `tightSelfClosing` mode, w/ space after an unquoted attribute (1)'
+  )
+
   t.deepEqual(
     toHtml(h('img', {src: 'index.jpg'}), {
       preferUnquoted: true,
       closeSelfClosing: true,
       tightSelfClosing: true
     }),
-    '<img src=index.jpg/>',
-    'should serialize voids with `/` in `closeSelfClosing` and `tightSelfClosing` mode, without space after an unquoted attribute'
+    '<img src=index.jpg />',
+    'should serialize voids with `/` in `closeSelfClosing` and `tightSelfClosing` mode, w/ space after an unquoted attribute (2)'
   )
 
   t.deepEqual(