Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer berachain weth decimals fix #3524

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

parodime
Copy link
Collaborator

@parodime parodime commented Feb 18, 2025

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • New Features
    • Enhanced token amount displays by providing clearer descriptions for native chain gas.
    • Added support for additional tokens, including Berachain WETH and BSC ETH, to ensure improved consistency in value formatting.

@parodime parodime requested a review from trajan0x as a code owner February 18, 2025 19:01
Copy link
Contributor

coderabbitai bot commented Feb 18, 2025

Walkthrough

The pull request updates the token formatting utility by modifying the ADDRESSES_WITH_18_DECIMALS array in the formatAmount.ts file. The comment for the ETH address has been revised to indicate it represents "native chain gas (eg: ETH)" instead of a generic label, and two new addresses have been added for "Berachain WETH" and "BSC ETH". The core logic of the formatAmount function remains unchanged.

Changes

File Change Summary
packages/.../formatAmount.ts Updated ETH address comment to "native chain gas (eg: ETH)" and added two new addresses: "Berachain WETH" and "BSC ETH".

Possibly related PRs

Suggested labels

go, size/xs, needs-go-generate-services/rfq

Suggested reviewers

  • trajan0x
  • dwasse

Poem

I'm a little rabbit on the run,
Dancing through lines of knitty fun.
Updating tokens with a hop and a skip,
My code garden grows—a technological trip!
With Berachain and BSC in our little mix,
Here’s to new changes, straight from my rabbit fix!
🐰✨

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
packages/rfq-indexer/indexer/src/utils/formatAmount.ts (1)

12-19: Consider making the decimal handling more flexible.

The current implementation assumes tokens have either 18 or 6 decimals. This binary approach might be fragile as new tokens with different decimal places could be added in the future.

Consider:

  1. Fetching decimals from token contracts directly
  2. Using a more comprehensive mapping of token addresses to their decimal places
  3. Adding error handling for invalid addresses

Would you like me to propose a more robust implementation?

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2787318 and 5d48a85.

📒 Files selected for processing (1)
  • packages/rfq-indexer/indexer/src/utils/formatAmount.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: test
  • GitHub Check: lint
  • GitHub Check: changesets-integrity-checker
  • GitHub Check: test
  • GitHub Check: lint
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
packages/rfq-indexer/indexer/src/utils/formatAmount.ts (1)

4-4: LGTM! Improved clarity in the comment.

The updated comment better describes the purpose of this address as native chain gas.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d48a85
Status: ✅  Deploy successful!
Preview URL: https://6bd8aea7.sanguine-fe.pages.dev
Branch Preview URL: https://parod-indx-bera-weth-fix.sanguine-fe.pages.dev

View logs

@parodime parodime merged commit c69e3c1 into master Feb 18, 2025
30 of 33 checks passed
@parodime parodime deleted the parod/indx_bera_weth_fix branch February 18, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant