-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indexer berachain weth decimals fix #3524
Conversation
WalkthroughThe pull request updates the token formatting utility by modifying the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/rfq-indexer/indexer/src/utils/formatAmount.ts (1)
12-19
: Consider making the decimal handling more flexible.The current implementation assumes tokens have either 18 or 6 decimals. This binary approach might be fragile as new tokens with different decimal places could be added in the future.
Consider:
- Fetching decimals from token contracts directly
- Using a more comprehensive mapping of token addresses to their decimal places
- Adding error handling for invalid addresses
Would you like me to propose a more robust implementation?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/rfq-indexer/indexer/src/utils/formatAmount.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: test
- GitHub Check: lint
- GitHub Check: changesets-integrity-checker
- GitHub Check: test
- GitHub Check: lint
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
packages/rfq-indexer/indexer/src/utils/formatAmount.ts (1)
4-4
: LGTM! Improved clarity in the comment.The updated comment better describes the purpose of this address as native chain gas.
Deploying sanguine-fe with
|
Latest commit: |
5d48a85
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6bd8aea7.sanguine-fe.pages.dev |
Branch Preview URL: | https://parod-indx-bera-weth-fix.sanguine-fe.pages.dev |
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit