Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api test fixes #3228

Merged
merged 1 commit into from
Oct 4, 2024
Merged

api test fixes #3228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/rest-api/src/constants/bridgeable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ export const USDC: BridgeableToken = {
[CHAINS.AVALANCHE.id]: '0xb97ef9ef8734c71904d8002f8b6bc66dd9c48a6e',
[CHAINS.DFK.id]: '0x3AD9DFE640E1A9Cc1D9B0948620820D975c3803a',
[CHAINS.BASE.id]: '0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913',
[CHAINS.POLYGON.id]: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174',
[CHAINS.POLYGON.id]: '0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Remove all remaining references to the old USDC address on the POLYGON chain

The old USDC token address '0x2791bca1f2de4661ed88a30c99a7a9449aa84174' is still referenced in multiple parts of the codebase. This could lead to inconsistencies and potential issues with integrations.

  • Files containing the old address:
    • packages/synapse-interface/constants/tokens/bridgeable.ts
    • packages/widget/src/constants/bridgeable.ts
    • packages/rest-api/src/constants/bridgeable.ts

Please update or remove these references to ensure consistency across the codebase.

🔗 Analysis chain

Verify the new USDC address for POLYGON chain

The USDC token address for the POLYGON chain has been updated. This is a significant change that could affect existing integrations and user interactions.

-    [CHAINS.POLYGON.id]: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174',
+    [CHAINS.POLYGON.id]: '0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359',

Please ensure that this new address is correct and that all necessary updates have been made in other parts of the codebase that might reference this address.

To verify the correctness of this address, you can run the following script:

This script will search for occurrences of both the new and old addresses, helping to ensure consistency across the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the new USDC address on Polygon
echo "Verifying USDC address on Polygon"
rg --type typescript "0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359" -C 5
echo "Checking for any remaining occurrences of the old address"
rg --type typescript "0x2791bca1f2de4661ed88a30c99a7a9449aa84174" -C 5

Length of output: 548

Script:

#!/bin/bash
# Verify the new USDC address on Polygon with corrected file type
echo "Verifying USDC address on Polygon"
rg --type ts "0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359" -C 5
echo "Checking for any remaining occurrences of the old address"
rg --type ts "0x2791bca1f2de4661ed88a30c99a7a9449aa84174" -C 5

Length of output: 29272

[CHAINS.SCROLL.id]: '0x06eFdBFf2a14a7c8E15944D1F4A48F9F95F663A4',
[CHAINS.LINEA.id]: '0x176211869cA2b568f2A7D4EE941E073a821EE1ff',
},
Expand Down Expand Up @@ -994,6 +994,7 @@ export const USDCe: BridgeableToken = {
[CHAINS.AVALANCHE.id]: '0xA7D7079b0FEaD91F3e65f86E8915Cb59c1a4C664',
[CHAINS.ARBITRUM.id]: '0xff970a61a04b1ca14834a43f5de4533ebddb5cc8',
[CHAINS.AURORA.id]: '0xB12BFcA5A55806AaF64E99521918A4bf0fC40802',
[CHAINS.POLYGON.id]: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174',
},
decimals: {
[CHAINS.OPTIMISM.id]: 6,
Expand Down
Loading