fix(solidity-devops): correctly save new deployments when script entry function is not `run()` #2883

ChiTimesChi · 2024-07-17T18:16:39Z

Description
See title.

Summary by CodeRabbit

New Features
- Enhanced deployment receipt functionality to use current timestamps, ensuring accurate retrieval of new deployment receipts.

coderabbitai · 2024-07-17T18:16:45Z

Walkthrough

The updates introduce a timestamp parameter to the getNewDeploymentReceipts function in deployments.js, enhancing its functionality by allowing it to read files based on the provided timestamp. Correspondingly, forgeScriptRun.js has been updated to pass this new timestamp parameter when calling getNewDeploymentReceipts. These modifications improve the ability to retrieve deployment receipts accurately based on time.

Changes

File Path	Change Summary
packages/.../js/forgeScriptRun.js	Added a `currentTimestamp` parameter to the `getNewDeploymentReceipts` function call.
packages/.../js/utils/deployments.js	Updated `getNewDeploymentReceipts` to accept a `timestamp` parameter for reading files based on it.

Poem

In the world of code where timestamps play,
Deployment receipts now have their say.
With precision and care, they sort through the night,
Ensuring no data falls out of sight.
Cheers to the changes, simple yet grand,
As we march forward, hand in hand. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

greptile-apps

PR Summary

Updated packages/solidity-devops/js/forgeScriptRun.js to include currentTimestamp in getNewDeploymentReceipts call.
Modified packages/solidity-devops/js/utils/deployments.js to add timestamp parameter in getNewDeploymentReceipts.
Ensured accurate tracking and saving of deployment receipts based on script execution time.

_{2 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings}

packages/solidity-devops/js/utils/deployments.js

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 92b5efa and d6ee532.

Files selected for processing (2)

packages/solidity-devops/js/forgeScriptRun.js (1 hunks)
packages/solidity-devops/js/utils/deployments.js (1 hunks)

Additional comments not posted (2)

packages/solidity-devops/js/forgeScriptRun.js (1)

61-65: Ensure correct parameter passing to getNewDeploymentReceipts.

The addition of currentTimestamp to getNewDeploymentReceipts is correctly implemented. This change aligns with the PR's objective to handle deployments irrespective of the entry function's name, ensuring that deployment receipts are fetched based on the current timestamp.

packages/solidity-devops/js/utils/deployments.js (1)

180-196: Review the updated getNewDeploymentReceipts function.

The addition of the timestamp parameter to getNewDeploymentReceipts is correctly implemented. The function now filters files based on the timestamp, ensuring that only recent deployment receipts are processed. This is a crucial update for handling deployments dynamically based on when they were created, which supports the PR's goal of improving the robustness of deployment tracking.

cloudflare-workers-and-pages · 2024-07-17T18:21:11Z

Deploying sanguine-fe with Cloudflare Pages

Latest commit:	`9e5e96d`
Status:	✅ Deploy successful!
Preview URL:	https://81d45574.sanguine-fe.pages.dev
Branch Preview URL:	https://fix-solidity-devops-new-depl.sanguine-fe.pages.dev

View logs

codecov · 2024-07-17T18:23:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47619%. Comparing base (80b8e29) to head (9e5e96d).
Report is 4 commits behind head on master.

Additional details and impacted files

@@                 Coverage Diff                  @@
##              master       #2883          +/-   ##
====================================================
+ Coverage   27.04966%   90.47619%   +63.42653%     
====================================================
  Files            116          54          -62     
  Lines           5135        1008        -4127     
  Branches          80          80                  
====================================================
- Hits            1389         912         -477     
+ Misses          3701          93        -3608     
+ Partials          45           3          -42

Flag	Coverage Δ
git-changes-action	`?`
opbot	`?`
packages	`90.47619% <ø> (ø)`
promexporter	`?`
screener-api	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

greptile-apps

PR Summary

(updates since last review)

Added check for broadcast directory existence in /packages/solidity-devops/js/utils/deployments.js
Logged error if broadcast directory does not exist to prevent runtime errors

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d6ee532 and 9e5e96d.

Files selected for processing (1)

packages/solidity-devops/js/utils/deployments.js (1 hunks)

Files skipped from review as they are similar to previous changes (1)

packages/solidity-devops/js/utils/deployments.js

ChiTimesChi added 2 commits July 17, 2024 19:14

fix: latest broadcast file is not always "run-latest"

c58e7e2

fix: use timestamp when fetching new receipts

d6ee532

ChiTimesChi requested a review from trajan0x as a code owner July 17, 2024 18:16

github-actions bot added javascript Pull requests that update Javascript code size/xs labels Jul 17, 2024

greptile-apps bot reviewed Jul 17, 2024

View reviewed changes

packages/solidity-devops/js/utils/deployments.js Show resolved Hide resolved

coderabbitai bot reviewed Jul 17, 2024

View reviewed changes

fix: silent exit if broadcast directory doesn't exist

9e5e96d

greptile-apps bot reviewed Jul 17, 2024

View reviewed changes

coderabbitai bot reviewed Jul 17, 2024

View reviewed changes

ChiTimesChi changed the title ~~fix(solidify-devops): correctly save new deployments when script entry function is not run()~~ fix(solidity-devops): correctly save new deployments when script entry function is not run() Jul 17, 2024

ChiTimesChi merged commit fd337e9 into master Jul 17, 2024
50 checks passed

ChiTimesChi deleted the fix/solidity-devops-new-deployments branch July 17, 2024 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(solidity-devops): correctly save new deployments when script entry function is not `run()` #2883

fix(solidity-devops): correctly save new deployments when script entry function is not `run()` #2883

ChiTimesChi commented Jul 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 17, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

greptile-apps bot left a comment

coderabbitai bot left a comment

cloudflare-workers-and-pages bot commented Jul 17, 2024 •

edited

Loading

codecov bot commented Jul 17, 2024 •

edited

Loading

greptile-apps bot left a comment

coderabbitai bot left a comment

fix(solidity-devops): correctly save new deployments when script entry function is not run() #2883

fix(solidity-devops): correctly save new deployments when script entry function is not run() #2883

Conversation

ChiTimesChi commented Jul 17, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jul 17, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

coderabbitai bot left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Jul 17, 2024 • edited Loading

Deploying sanguine-fe with Cloudflare Pages

codecov bot commented Jul 17, 2024 • edited Loading

Codecov Report

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

coderabbitai bot left a comment

Choose a reason for hiding this comment

fix(solidity-devops): correctly save new deployments when script entry function is not `run()` #2883

fix(solidity-devops): correctly save new deployments when script entry function is not `run()` #2883

ChiTimesChi commented Jul 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 17, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Jul 17, 2024 •

edited

Loading

codecov bot commented Jul 17, 2024 •

edited

Loading