test(sdk-router): error console cleanup (#3379)

* test: ignore console.error in negative API cases

* test: better fetch mock to simulate empty list of quotes

* test: partially apply  Rabbit suggestion

* test: retry for flaky tests

packages/sdk-router/src/rfq/api.integration.test.ts

@@ -2,6 +2,9 @@ import { getAllQuotes } from './api'
 
 global.fetch = require('node-fetch')
 
+// Retry the flaky tests up to 3 times
+jest.retryTimes(3)
+
 describe('getAllQuotes', () => {
   it('Integration test', async () => {
     const result = await getAllQuotes()

packages/sdk-router/src/rfq/api.test.ts

@@ -76,16 +76,28 @@ describe('getAllQuotes', () => {
   })
 
   describe('Returns an empty array', () => {
+    beforeEach(() => {
+      jest.spyOn(console, 'error').mockImplementation(() => {
+        // Do nothing
+      })
+    })
+
+    afterEach(() => {
+      jest.restoreAllMocks()
+    })
+
     it('when the response is not ok', async () => {
       fetchMock.mockResponseOnce(JSON.stringify(quotesAPI), { status: 500 })
       const result = await getAllQuotes()
       expect(result).toEqual([])
+      expect(console.error).toHaveBeenCalled()
     })
 
     it('when fetch throws an error', async () => {
       fetchMock.mockRejectOnce(new Error('Error fetching quotes'))
       const result = await getAllQuotes()
       expect(result).toEqual([])
+      expect(console.error).toHaveBeenCalled()
     })
 
     it('when the response takes too long to return', async () => {
@@ -94,6 +106,7 @@ describe('getAllQuotes', () => {
       )
       const result = await getAllQuotes()
       expect(result).toEqual([])
+      expect(console.error).toHaveBeenCalled()
     })
   })
 })

packages/sdk-router/src/sdk.test.ts

@@ -48,10 +48,14 @@ import * as operations from './operations'
 // Override fetch to exclude RFQ from tests
 global.fetch = jest.fn(() =>
   Promise.resolve({
-    json: () => Promise.resolve({}),
+    ok: true,
+    json: () => Promise.resolve([]),
   })
 ) as any
 
+// Retry the flaky tests up to 3 times
+jest.retryTimes(3)
+
 const EXPECTED_GAS_DROP: { [chainId: number]: BigNumber } = {
   [SupportedChainId.ETH]: BigNumber.from(0),
   // TODO: reenable once both ARB airdrops are adjusted