Pass the namespace parameter to cacheable instances #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump @nitriques? I'll merge soon, I have it working in production on a client site so the risk seems small. |
brendo
force-pushed
the
feature_use-namespaced-cache
branch
from
4e4f645 to
71be057
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Symphony
Cacheableclass has namespaced support but the Remote Datasource extension doesn't use it. This PR updates Remote Datasource to pass through a namespace value. This enables (among other things), simple clearing of datasources by flushing everything by a$namespacevalue rather than reconstructing individual cache ID's: