Custom CSV Styles

[nilshoerrmann]

• allows custom CSV styles, e. g. using ; as delimiter instead of , (this is common in Germany)
• fixes the {$workspace} path

[brendo]

Curious why WORKSPACE wasn't working? The new constant won't always be correct

[nilshoerrmann]

I got 404 errors with the old constant (although the returned server path was correct). The change is a result of trial and error.

[nilshoerrmann]

The main problem is, that {$root} returns a public URL (http://example.com) while the previous implementation of {$workspace} returned a server path (/something/public/www/example.com). Any reason for that?

[nitriques]

I could be wrong, but WORKSPACE has always been a server path... no ?

[nitriques]

Just like EXTENSIONS

[nilshoerrmann]

That might be true in the backend, but not on the frontend. The system param $workspace has never been a server path.

[nitriques]

O I was thinking about the PHP constant... Sorry.

[nilshoerrmann]

It's difficult :) It's the $workspace parameter as we use it in the DSE. So this should be an URL in my eyes. Remote Data Source grants access to $root and $workspace but the first will be converted to an URL and the second to a server path right now.

[nilshoerrmann]

It it's of course possible that I completely misunderstood something.

[nitriques]

Oooo. Nice mix up :)

[nilshoerrmann]

The new constant won't always be correct

@brendo, can you please give me a hint when this wouldn't be correct. We are using these changes without issues so far.

[brendo]

@brendo, can you please give me a hint when this wouldn't be correct. We are using these changes without issues so far.

And for the majority it'll be fine :) It's just if a developer plays with the constants of Symphony to rename /workspace as something else.

[nilshoerrmann]

And how can I fix this? Because the original WORKSPACE is returning a server path and not a URL as it should.

[nitriques]

I am ok with it. Right now, this is a bug. (WORKSPACE vs URL).