Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External image problem #130

Open
wdebusschere opened this issue Jun 21, 2016 · 1 comment
Open

External image problem #130

wdebusschere opened this issue Jun 21, 2016 · 1 comment
Assignees
@nitriques
Labels
Bug Fixed in integration
Milestone
2.1.0

Comments

@wdebusschere
Copy link

wdebusschere commented Jun 21, 2016 •
edited
Loading

Latest Symphony + jit_image_manipulation 2.02

External images not working:
path: http://localhost:8080/www.site.ext/image/1/640/480/1/www.externaldomain/pictures/2787AL.jpg

Debugging i see that in class lib/jit.image.php $parameters['external'] should be $parameters['settings']['external']

public function fetchImagePath(array &$parameters)
{
// Fetch external images
if ($parameters['external'] === true) {
@nitriques
Copy link
Member

Thanks @wdebusschere

nitriques added a commit to DeuxHuitHuit/jit_image_manipulation that referenced this issue Jun 22, 2016
@nitriques
External key is part of the settings array
297d83f 
Fixes symphonycms#130
@nitriques nitriques added this to the 2.1.0 milestone Jun 22, 2016
@nitriques nitriques self-assigned this Jun 22, 2016
@nitriques nitriques mentioned this issue Jul 21, 2016
Open
3 tasks
nitriques added a commit that referenced this issue Jul 28, 2016
@nitriques
Refactor around HEAD requests
72b6a44 
The way we handled HEAD request was

1. Different from the GET request, since it lacked some checks
2. Way to general for our needs

This commit refactors the old things with a single brand new function
that will

1. Make sure the request is a 200
2. Return only cache related headers, since that's the goal

Re #136
Cc #138
Cc #130
Cc #137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitriques nitriques

Labels
Bug Fixed in integration
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@nitriques @wdebusschere