Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

[SYM-5015] Add prompt_field.on_change #159

Conversation

Arianna2028
Copy link
Contributor

@Arianna2028 Arianna2028 commented Aug 8, 2023

Description

Adds a new on_change attribute to the prompt_field block. This takes in Python file contents just like sym_flow.implementation and should contain a function on_change_<prompt_field.name> that will be executed when the field's value changes in the request form. However, we are not validating the Python here.

Testing

File paths are not permitted
CleanShot 2023-08-08 at 13 51 41

Create
CleanShot 2023-08-08 at 13 46 22

Read/Update
CleanShot 2023-08-08 at 13 46 05

Delete
CleanShot 2023-08-08 at 13 45 19

Destroy
CleanShot 2023-08-08 at 13 49 43

@linear
Copy link

linear bot commented Aug 8, 2023

SYM-5015 Add on_change to promptFieldResource in the Sym Terraform Provider

Note: The Terraform Provider changes should NOT be publicly released until the project is feature-complete. An alpha version of the Terraform Provider may be released for testing, however.

@Arianna2028
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@Arianna2028 Arianna2028 marked this pull request as ready for review August 8, 2023 18:08
@Arianna2028 Arianna2028 requested a review from a team August 8, 2023 18:08
Copy link
Contributor

@llam15 llam15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only nit is maybe updating the sample on_change methods?

@Arianna2028 Arianna2028 merged commit 6f5df8f into main Aug 9, 2023
@Arianna2028 Arianna2028 deleted the ari/sym-5015-add-on_change-to-promptfieldresource-in-the-sym-terraform branch August 9, 2023 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants