Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

[SYM-3790] Followup: fix sym_flow resource acceptance test #109

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

Arianna2028
Copy link
Contributor

Last 2 PRs had some conflicting changes that broke a test so this fixes that.

@linear
Copy link

linear bot commented Jun 6, 2022

SYM-3790 Support Flows without scheduled de-escalation

For context, see the AaaS ADR.

Add an optional schedule_deescalation boolean (default true) to the params of a sym_flow resource that, when false, suppresses scheduling of the deescalate event. This should be at the params level alongside the existing allow_revoke.

This will require Terraform provider (specifically, /sym/templates/sym_approval.go) and platform changes.

Also add queuer API-level validations that if schedule_deescalation is false, then allow_revoke must be true and duration must not be specified in the prompt_fields (but Flows may still have a duration; we will just ignore it—we'll make this better in SYM-3791).

Example Terraform:

resource "sym_flow" "custom" {
  # ...
  params = {
    strategy_id           = sym_strategy.custom[0].id
    schedule_deescalation = false
    allow_revoke          = true
    prompt_fields_json    = jsonencode([
      {
        name     = "identifier"
        label    = "What animal would you like?"
        type     = "string"
        required = true
      }
    ])
  }
}

@Arianna2028 Arianna2028 requested review from druiz and a team June 6, 2022 16:06
@Arianna2028 Arianna2028 merged commit 6189a05 into main Jun 6, 2022
@Arianna2028 Arianna2028 deleted the ari/sym-3790-followup branch June 6, 2022 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants