Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

fix: target_id -> identifier in acceptance test #104

Merged
merged 2 commits into from
Apr 29, 2022
Merged

fix: target_id -> identifier in acceptance test #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88258c9
fix: target_id -> identifier in acceptance test
Arianna2028 Apr 29, 2022
78dc8fd
fix: custom strategy test target
Arianna2028 Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sym/provider/strategy_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ func customStrategy(t TestData, label, implPath string) string {
name: t.ResourcePrefix + "-custom-target",
label: "Custom Target",
settings: map[string]string{
"target_id": "hello-i-am-target",
"identifier": "hello-i-am-target",
},
}.String())

Expand Down
8 changes: 4 additions & 4 deletions sym/provider/target_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func TestAccSymTarget_custom(t *testing.T) {
resource.TestCheckResourceAttr("sym_target.custom", "type", "custom"),
resource.TestCheckResourceAttr("sym_target.custom", "name", createData.ResourceName),
resource.TestCheckResourceAttr("sym_target.custom", "label", "My Custom Target"),
resource.TestCheckResourceAttr("sym_target.custom", "settings.target_id", "am-target"),
resource.TestCheckResourceAttr("sym_target.custom", "settings.identifier", "am-target"),
),
},
{
Expand All @@ -94,7 +94,7 @@ func TestAccSymTarget_custom(t *testing.T) {
resource.TestCheckResourceAttr("sym_target.custom", "type", "custom"),
resource.TestCheckResourceAttr("sym_target.custom", "name", updateData.ResourceName),
resource.TestCheckResourceAttr("sym_target.custom", "label", "Other Custom Target"),
resource.TestCheckResourceAttr("sym_target.custom", "settings.target_id", "am-still-target"),
resource.TestCheckResourceAttr("sym_target.custom", "settings.identifier", "am-still-target"),
),
},
},
Expand Down Expand Up @@ -136,7 +136,7 @@ func awsIamTarget(t TestData, label, iamGroup string) string {
return sb.String()
}

func customTarget(t TestData, label, targetId string) string {
func customTarget(t TestData, label, identifier string) string {
var sb strings.Builder

sb.WriteString(providerResource{org: t.OrgSlug}.String())
Expand All @@ -146,7 +146,7 @@ func customTarget(t TestData, label, targetId string) string {
type_: "custom",
label: label,
settings: map[string]string{
"target_id": targetId,
"identifier": identifier,
},
}.String())

Expand Down