Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Sql Field name because it's reserved #5567

Merged
merged 1 commit into from
Jul 28, 2015
Merged

Change Sql Field name because it's reserved #5567

merged 1 commit into from
Jul 28, 2015

Conversation

rmed19
Copy link
Contributor

@rmed19 rmed19 commented Jul 28, 2015

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #5566

@javiereguiluz
Copy link
Member

@rmed19 👍 for changing the name. However, I'd like to propose a different new name. What if we use created_at name, which is more common for PHP applications? In any case, please don't change anything until we have the opinion of the documentation managers. Thanks.

@wouterj
Copy link
Member

wouterj commented Jul 28, 2015

👍

@wouterj wouterj merged commit 5daa5f8 into symfony:2.3 Jul 28, 2015
wouterj added a commit that referenced this pull request Jul 28, 2015
@wouterj
bug #5567 Change Sql Field name because it's reserved (rmed19)
128f324 
This PR was merged into the 2.3 branch.

Discussion
----------

Change Sql Field name because it's reserved

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #5566

Commits
-------

5daa5f8 Change Sql Field name because it's reserved
wouterj added a commit that referenced this pull request Jul 28, 2015
@wouterj
[#5567] Renamed created_date to created_at
0134123 
This seems to be more common.
@wouterj
Copy link
Member

wouterj commented Jul 28, 2015

Thank you @rmed19 for catching this error. Congratz on your first ever doc contribution! You'll receive the doc contributor badge within some days.

I've renamed the column to created_at, as proposed by @javiereguiluz in 0134123 after merging your PR. If you don't agree with this change, feel free to comment.

@rmed19
Copy link
Contributor Author

rmed19 commented Jul 28, 2015

Yes, created_at is more common, so it's will be better to change created_date to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmed19 @javiereguiluz @wouterj