use the include() Twig function instead of the tag #5548
Conversation
xabbuh
commented
Jul 22, 2015
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
| section that you want to direct the user to. #} | ||
| {% include '@WebProfiler/Profiler/toolbar_item.html.twig' with { 'link': true } %} | ||
| {{ include('@WebProfiler/Profiler/toolbar_item.html.twig', variables = { 'link': true }) }} |
There was a problem hiding this comment.
The variables name is completely optional and very verbose. What about dispalying the short version first and mention that, as usual in Twig functions/filters, you can name the variable if you prefer?
{{ include('@WebProfiler/Profiler/toolbar_item.html.twig', { 'link': true }) }}There was a problem hiding this comment.
Good catch, Javier. I don't think we should talk about named arguments here at all as it's a too common concept in Twig to be mentioned in every Twig function we use.
xabbuh
force-pushed
the
twig-include-function
branch
from
cd3729c to
f0d4ea4
Compare
| The `include() function`_ is a new Twig feature that's available in Symfony | ||
| 2.2. Prior, the `{% include %} tag`_ tag was used. | ||
| 2.3. Prior, the `{% include %} tag`_ tag was used. |
There was a problem hiding this comment.
the function was introduced in Twig 1.12, supported by all Symfony 2.x releases. Not sure if we need this versionadded at all...
There was a problem hiding this comment.
In the contribution docs we have it with 2.3. Since Symfony 2.3 was the first version requiring Twig 1.12 or above (Symfony 2.2 could have been used with Twig 1.11) I decided to make the change here. But I don't have any hard feelings about this. It should just be consistent.
|
👍 |
|
Looks good to me - thanks for updating these! |
This PR was merged into the 2.3 branch. Discussion ---------- use the include() Twig function instead of the tag | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- f0d4ea4 use the include() Twig function instead of the tag
