Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite sentence about fingers crossed handler action level #5414

Merged
merged 2 commits into from
Jun 29, 2015
Merged

Rewrite sentence about fingers crossed handler action level #5414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2982000
5370 rewrite sentence about fingers crossed handler action level
Jun 19, 2015
ebebe1d
5370 simplify original sentence
Jun 22, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cookbook/logging/monolog_email.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,10 @@ it is broken down.

The ``mail`` handler is a ``fingers_crossed`` handler which means that
it is only triggered when the action level, in this case ``critical`` is reached.
It then logs everything including messages below the action level. The
``critical`` level is only triggered for 5xx HTTP code errors. The ``handler``
setting means that the output is then passed onto the ``buffered`` handler.
The ``critical`` level is only triggered for 5xx HTTP code errors. If this level
is reached once, the ``fingers_crossed`` handler will log all messages
regardless of their level. The ``handler`` setting means that the output
is then passed onto the ``buffered`` handler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we go a bit further and simplify the original sentence even more? For example:

If this level is reached once, the ``fingers_crossed`` handler will log all messages
regardless of their level.

.. tip::

Expand Down