Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style standardization on form type options #4967

Closed
wants to merge 2 commits into from
Closed

Code style standardization on form type options #4967

wants to merge 2 commits into from

Conversation

mimol91
Copy link
Contributor

@mimol91 mimol91 commented Feb 6, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets ~

I m not quite sure how to set proper name for bool attributes.
I read on SF Code standards "For type-hinting in PHPDocs and casting, use bool (instead of boolean or Boolean)", however I change it to boolean. (Most commonly used)

@mimol91 mimol91 force-pushed the form-type-standardization branch 2 times, most recently from 70a4484 to c06967c Compare February 6, 2015 20:43
@mimol91 mimol91 force-pushed the form-type-standardization branch from c06967c to b37314b Compare February 6, 2015 20:48
@wouterj
Copy link
Member

wouterj commented Feb 6, 2015

Thank you for the work you've done. However, I think most of these changes are covered by #4956 and #4671 Can you please remove all changes that are also in one of those 2 PRs, so we're left with only the remaining issues?

@mimol91
Copy link
Contributor Author

mimol91 commented Feb 7, 2015

Is there any git command to remove this changes if there are on other commits?
I would rather not want to do it manually.
It is not any problem for me to wait until PR #4956 #4671 will be merged

@wouterj
Copy link
Member

wouterj commented Feb 7, 2015

Yes, that's fine by me

@xabbuh xabbuh added the On hold label Mar 8, 2015
@mimol91
Copy link
Contributor Author

mimol91 commented Jun 6, 2015

@wouterj
Hello. I merged changes.
Please let me know if it is OK

@xabbuh
Copy link
Member

xabbuh commented Jun 6, 2015

👍 looks great

@wouterj wouterj mentioned this pull request Jun 7, 2015
Merged
@wouterj
Copy link
Member

wouterj commented Jun 7, 2015

Hi @mimol91! Thanks for your work and taking care of updating this PR. Something still went wrong while trying to merge it, so I started a new branch and cherry-picked you commit. This resulted in a new PR: #5365 (you're still the author of the commit). I'll merge that PR, so I'll close this PR.

Thanks again!

@wouterj wouterj closed this Jun 7, 2015
wouterj added a commit that referenced this pull request Jun 7, 2015
@wouterj
minor #5365 Finish #4967: Code style standardization on form type opt…
75e4f70 
…ions (mimol91)

This PR was merged into the 2.3 branch.

Discussion
----------

Finish #4967: Code style standardization on form type options

Closes #4967

Commits
-------

b389f03 code style standardization on form type options
@mimol91
Copy link
Contributor Author

mimol91 commented Jun 7, 2015

@wouterj
Thanks. Good Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mimol91 @wouterj @xabbuh