Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick proofread of the email cookbook #4918

Merged
merged 3 commits into from
Jan 30, 2015
Merged

Quick proofread of the email cookbook #4918

merged 3 commits into from
Jan 30, 2015

Conversation

weaverryan
Copy link
Member

Hi guys!

Q A
Doc fix? no
New docs? no
Applies to 2.3+
Fixed tickets n/a

Pretty simple. The motivation was to show an example of the template that uses the new absolute_url function for 2.7. But then I wanted to change other stuff. So, after this is merged, I can make another PR for that.

Thanks!


// ...
}
the power of the `Swift Mailer`_ library. This bundles comes with the Symfony
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle

@javiereguiluz
Copy link
Member

👍 nice! After fixing the minor typo pointed by @xabbuh, I think we can consider this PR finished. Thanks!

@weaverryan weaverryan merged commit d32c51c into 2.3 Jan 30, 2015
weaverryan added a commit that referenced this pull request Jan 30, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Quick proofread of the email cookbook

Hi guys!

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | n/a

Pretty simple. The motivation was to show an example of the template that uses the new `absolute_url` function for 2.7. But then I wanted to change other stuff. So, after this is merged, I can make another PR for that.

Thanks!

Commits
-------

d32c51c Fixing typo thanks to xabbuh
5207800 Adding reference link
299ead1 Quick proofread of the email cookbook
@weaverryan weaverryan deleted the email-update branch January 30, 2015 02:41
weaverryan added a commit that referenced this pull request Jul 25, 2015
…buh)

This PR was merged into the 2.7 branch.

Discussion
----------

[Cookbook][Email] add missing versionadded directive

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7+
| Fixed tickets | #4918

Commits
-------

bc880d0 add missing versionadded directive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants