-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the Propel chapter from the Symfony book #4900
Removed the Propel chapter from the Symfony book #4900
Conversation
Should we create a cookbook section about Propel or move this to the PropelBundle and render the bundle doc on the website ? The advantage of putting this in the bundle is that the Prople team could provide the Propel2 version of the same cookbooks (in the 2.0 branch of the bundle) |
I'm 👍 for using the PropelBundle docs instead of the Propel cookbook |
I've removed the proposed Propel cookbook section |
@javiereguiluz this requires a rebase. Could you please also create a ticket in the propel repository, so they don't forget to add it to their docs? I also think their docs is linking to this doc? |
25ff743
to
b0a7538
Compare
The PR is now rebased and the issue has been opened in the PropelBundle repository: propelorm/PropelBundle#323 |
@javiereguiluz sorry for not flagging this as finished earlier, but this PR has some conflicts again. |
b0a7538
to
ccce90f
Compare
I've rebased the PR to fix conflicts. |
@javiereguiluz I don't like that an existing page will 404. Could we add just a little bit of content on the page that links over to the Propel docs? (https://github.com/propelorm/PropelBundle/blob/1.4/Resources/doc/index.markdown) Thanks! |
Hi @javiereguiluz. Can you please rebase this PR and apply what @weaverryan suggested? |
@javiereguiluz ping |
Closing it in favor of #5369 |
This is the first step into updating the Symfony Book. Most of these updates will consist on removing things.
The two main reasons for this change are: 1) the traffic to that book chapter is marginal; 2) Propel is a second or third class citizen in Symfony, whereas Doctrine is a first-class citizen.
One of the positive outcomes of this change is that we now have a cookbook section about Propel. This means that we could publish more short articles about Propel + Symfony and, in the long term, increase Propel awareness among Symfony community.