Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update templating.rst #4776

Closed
wants to merge 2 commits into from
Closed

Update templating.rst #4776

wants to merge 2 commits into from

Conversation

ifdattic
Copy link
Contributor

@ifdattic ifdattic commented Jan 5, 2015

Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets

@ifdattic
Update templating.rst
c87e7b6 
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |
ifdattic
ifdattic reviewed Jan 5, 2015
View reviewed changes
book/templating.rst
@@ -1507,7 +1521,7 @@ console command:
.. code-block:: bash

# You can check by filename:
$ php app/console twig:lint app/Resources/views/Article/recentList.html.twig
$ php app/console twig:lint app/Resources/views/Blog/index.html.twig
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to remove horizontal scrollbar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please rename index to post?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@xabbuh
Copy link
Member

xabbuh commented May 23, 2015

ping @ifdattic :)

@ifdattic
Copy link
Contributor Author

@xabbuh Yes, how can I help?

@xabbuh
Copy link
Member

xabbuh commented May 25, 2015

Can you make the changes proposed by @wouterj? Or is this something you want to check first? Imho these changes are not necessary, are they?

@ifdattic
Copy link
Contributor Author

I think a lot might have changed during the last few months so most of the changes are probably unnecessary.

At best a few typos would probably only be useful (if they were not fixed by this time)

@xabbuh xabbuh mentioned this pull request May 31, 2015
Merged
@xabbuh
Copy link
Member

xabbuh commented May 31, 2015

Closing in favor of #5344. Thank you for starting this @ifdattic.

@xabbuh xabbuh closed this May 31, 2015
@ifdattic
Copy link
Contributor Author

ifdattic commented Jun 1, 2015

Glad to help!

wouterj added a commit that referenced this pull request Jun 6, 2015
@wouterj
minor #5344 [Book] Finish #4776 and #4782 (ifdattic)
9eb96f6 
This PR was merged into the 2.3 branch.

Discussion
----------

[Book] Finish #4776 and #4782

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4776, #4782

Commits
-------

88bd859 Update form.rst and templating.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ifdattic @xabbuh @wouterj