Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Configuration] update text to use SetHandler (not ProxyPassMatch) #4762

Merged
merged 1 commit into from
Jan 4, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 4, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

This reflects the changes to the default configuration introduced with #4708 in the introduction.

@xabbuh
Copy link
Member Author

xabbuh commented Jan 4, 2015

@TeLiXj For ProxyPassMatch we have a sentence below the config example talking about a subpath of the document root:

When you run your Symfony application on a subpath of your document root,
the regular expression used in ProxyPassMatch directive must be changed
accordingly

Do we need something similar for SetHandler?

@TeLiXj
Copy link
Contributor

TeLiXj commented Jan 4, 2015

I couldn't test this tip with ProxyPassMatch, but now with SetHandler I created a php file with phpinfo() on a subfolder of my web folder and I can see "Server API FPM/FastCGI "... it works without any modification in SetHandler

@xabbuh
Copy link
Member Author

xabbuh commented Jan 4, 2015

Thank you @TeLiXj. In this case it makes sense to move the description for the modified ProxyPassMatch description to a comment.

@weaverryan
Copy link
Member

Great attention to detail on this :). Thanks @xabbuh!

@weaverryan weaverryan merged commit 9d84d03 into symfony:2.3 Jan 4, 2015
weaverryan added a commit that referenced this pull request Jan 4, 2015
…not ProxyPassMatch) (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Configuration] update text to use SetHandler (not ProxyPassMatch)

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

This reflects the changes to the default configuration introduced with #4708 in the introduction.

Commits
-------

9d84d03 update text to use SetHandler (not ProxyPassMatch)
@xabbuh xabbuh deleted the reword-apache-fpm branch January 5, 2015 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants