Mention @Security() annotation instead of @Secure() #4733

javiereguiluz · 2015-01-02T14:23:10Z

Q	A
Doc fix?	no
New docs?	yes
Applies to	2.4+
Fixed tickets	-

Beware that (if accepted) this PR must be merged in 2.4+ because @Security isn't available in Symfony 2.3.

xabbuh · 2015-01-02T14:28:07Z

I think we should simply merge this into the 2.5 branch.

By the way, you would have to revert the 2.6 specific changes.

stof · 2015-01-02T16:34:35Z

cookbook/security/remember_me.rst

     */
    public function editAction($name)
    {
        // ...
    }

+.. versionadded:: 2.4
+    The ``@Security`` annotation was introduced in SensioFrameworkExtraBundle 3.0,
+    which can only be used with Symfony 2.4 or later.


this is not true technically. Other features of SensioFrameworkExtraBundle 3.0 can be used in Symfony 2.3

I copied this note from this other note:

The @Security annotation was introduced in SensioFrameworkExtraBundle 3.0. This bundle version can only be used with Symfony 2.4 or later (see the SensioFrameworkExtraBundle release cycle).

Source: http://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/security.html

Should we also fix the original note?

As I said here, we shouldn't over-complicate things here. Even the bundle's readme just states "The minimum version of Symfony2 for this workflow is 2.4.0.".

The `@Security` annotation was introduced in SensioFrameworkExtraBundle 3.0 which requires Symfony 2.4 or higher. This change has to be reverted in the `2.5` branch once it got merged up.

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.5 | Fixed tickets |

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.6 | Fixed tickets |

The class loader is located in the Debug component and not in the ClassLoader component.

This PR was merged into the 2.5 branch. Discussion ---------- [Book][Validation] clarify group validation | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | 2.5+ | Fixed tickets | part of symfony#4094 This is for item `F` of symfony#4094. Actually, we didn't have anything wrong as long as I didn't miss anything. I only made two little changes to fix a sentence and clarify the legacy API. Commits ------- 1c79cad clarify group validation

This PR was merged into the 2.6 branch. Discussion ---------- Update templating.rst | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.6 | Fixed tickets | Commits ------- 851be38 Update templating.rst

This PR was merged into the 2.6 branch. Discussion ---------- Fix markup versionadded directives are quite strange, as it doesn't allow to have empty lines in it. So both code blocks were rendered as a blockquote (using shortcut) and PHP code for the main text (using code-block directive). This fixes it and also fixes some other markup errors. Commits ------- ab66a12 Fix markup

This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Routing] Fixed typo | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | Commits ------- 0a60deb [Cookbook][Routing] Fixed typo

Displaying the message of an `AuthenticationException` might expose sensitive data to the user.

Conflicts: changelog.rst

…book (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Removed the Stable API chapter from the Symfony book | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | - The two main reasons for this change are: 1) the traffic to that book chapter is almost zero; 2) all the things explained in this "chapter" are better explained in the BC Promise article. A redirection to that article has been setup. Commits ------- 42269d4 Removed the Stable API chapter from the Symfony book

… in PHP templates (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Added a reference about including JS and CSS files in PHP templates | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | symfony#4836 Commits ------- 5c6d4b2 Fixed a minor RST syntax issue 4d472c2 Added a reference about including JS and CSS files in PHP templates

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.4 | Fixed tickets |

This PR was submitted for the 2.4 branch but it was merged into the 2.5 branch instead (closes symfony#4928). Discussion ---------- Change installation method order | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.4 | Fixed tickets | Commits ------- 1db39c2 Update introduction.rst 475be21 Change installation method order

…s a little different)

* 2.3: [symfony#4928] Backporting change after merging into 2.5 (since 2.3 is a little different) Fixed a minor RST syntax issue Added a reference about including JS and CSS files in PHP templates Removed the Stable API chapter from the Symfony book Conflicts: book/stable_api.rst components/debug/introduction.rst

…ractices (ifdattic) This PR was merged into the 2.3 branch. Discussion ---------- Remove block which doesn't make sense after best practices | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- 26415e2 Remove block which doesn't make sense after best practices

This PR was merged into the 2.6 branch. Discussion ---------- Fixes for 2.6 branch | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.6 | Fixed tickets | Commits ------- 9ad21ea Fix typos 6e023c1 Fix typos

This PR was merged into the 2.3 branch. Discussion ---------- Fixes for 2.3 branch | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- e6ffd5d Add missing comma in array da70836 Fix typos

* 2.3: Add missing comma in array Fix typos Remove block which doesn't make sense after best practices

* 2.5: [symfony#4928] Backporting change after merging into 2.5 (since 2.3 is a little different) Update introduction.rst Change installation method order Add missing comma in array Fix typos Remove block which doesn't make sense after best practices Fixed a minor RST syntax issue Added a reference about including JS and CSS files in PHP templates Removed the Stable API chapter from the Symfony book

javiereguiluz · 2015-02-02T15:51:31Z

@xabbuh is there anything else left to be done in this PR before consider it finished? Thanks.

xabbuh · 2015-02-02T15:55:21Z

@javiereguiluz Given that 2.5 has reached the end of maintenance in the meantime, I think you can put back the 2.6 related changes. So this can then be merged into the 2.6 branch directly.

javiereguiluz · 2015-02-02T16:43:01Z

@xabbuh I've done what you said, so this PR is ready for the final review. Thanks.

xabbuh · 2015-02-02T16:59:47Z

👍

wouterj · 2015-02-03T11:23:05Z

@javiereguiluz could you please rebase this PR against 2.6? GH has lots of trouble with our submodules when switching form an unmaintained branch (2.4) to a maintained one.

javiereguiluz · 2015-02-03T14:10:23Z

Closed this pull request in favor of #4957

xabbuh added the Status: Needs Work label Jan 2, 2015

stof reviewed Jan 2, 2015
View reviewed changes

wouterj and others added 27 commits January 9, 2015 02:04

Fix markup

ab66a12

[Cookbook][Security] Hint about createToken can return null

528aa17

[Cookbook][Routing] Fixed typo

0a60deb

Changed email message instantiation to a more 'symfonysh' way.

7f8b051

[Book][Security] add back old anchors

68f36e3

remove @Security annotation for Symfony 2.3

493e7a9

The `@Security` annotation was introduced in SensioFrameworkExtraBundle 3.0 which requires Symfony 2.4 or higher. This change has to be reverted in the `2.5` branch once it got merged up.

bump required PHPUnit version

c5d4ce1

Update translation.rst

93bc1bf

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.5 | Fixed tickets |

Use path to be consistent

49971fb

Removed a leftover comma in security config sample

83be144

Fixed typo

3a7d0f4

Fixed 404 page

cc7853d

Fixed 404 page

c8a8b10

Fix code example

7970f76

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.5 | Fixed tickets |

Update override.rst

cc5564e

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |

Update override.rst

44b1584

Fixed broken link symfony#4827

05d1a64

Fixed typo

73f07ed

Fix typo: BLOG => BLOB

d83f005

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.6 | Fixed tickets |

[Components][Debug] fix DebugClassLoader namespace

32a589b

The class loader is located in the Debug component and not in the ClassLoader component.

Add custom link labels where Cookbook articles titles looked wrong

1b31ad1

minor symfony#4778 Update templating.rst (ifdattic)

a42e5b6

This PR was merged into the 2.6 branch. Discussion ---------- Update templating.rst | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.6 | Fixed tickets | Commits ------- 851be38 Update templating.rst

[symfony#4799] One little fix more

f7d99dd

don't output message from AuthenticationException

44277c7

Displaying the message of an `AuthenticationException` might expose sensitive data to the user.

wouterj and others added 17 commits February 1, 2015 15:45

Merge branch '2.5' into 2.6

fd0862b

Added January changelog

851024b

Fix build error in changelog

c5ce1de

Merge branch '2.3' into 2.5

6dd6735

Conflicts: changelog.rst

Merge branch '2.5' into 2.6

35093fa

Conflicts: changelog.rst

Change installation method order

475be21

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.4 | Fixed tickets |

Update introduction.rst

1db39c2

[symfony#4928] Backporting change after merging into 2.5 (since 2.3 i…

0afc689

…s a little different)

Merge branch '2.3' into 2.5

169315b

* 2.3: Add missing comma in array Fix typos Remove block which doesn't make sense after best practices

xabbuh added Status: Reviewed and removed Status: Needs Work labels Feb 2, 2015

javiereguiluz force-pushed the mention_security_annotation branch from 17ee9e8 to 6e273b8 Compare February 3, 2015 13:57

Mention @Security() annotation instead of @secure()

99163ed

javiereguiluz force-pushed the mention_security_annotation branch from 6e273b8 to 99163ed Compare February 3, 2015 14:03

javiereguiluz closed this Feb 3, 2015

javiereguiluz deleted the mention_security_annotation branch February 3, 2015 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mention @Security() annotation instead of @Secure() #4733

Mention @Security() annotation instead of @Secure() #4733

javiereguiluz commented Jan 2, 2015

xabbuh commented Jan 2, 2015

stof Jan 2, 2015

javiereguiluz Jan 2, 2015

xabbuh Jan 2, 2015

javiereguiluz commented Feb 2, 2015

xabbuh commented Feb 2, 2015

javiereguiluz commented Feb 2, 2015

xabbuh commented Feb 2, 2015

wouterj commented Feb 3, 2015

javiereguiluz commented Feb 3, 2015

Mention @Security() annotation instead of @Secure() #4733

Mention @Security() annotation instead of @Secure() #4733

Conversation

javiereguiluz commented Jan 2, 2015

xabbuh commented Jan 2, 2015

stof Jan 2, 2015

Choose a reason for hiding this comment

javiereguiluz Jan 2, 2015

Choose a reason for hiding this comment

xabbuh Jan 2, 2015

Choose a reason for hiding this comment

javiereguiluz commented Feb 2, 2015

xabbuh commented Feb 2, 2015

javiereguiluz commented Feb 2, 2015

xabbuh commented Feb 2, 2015

wouterj commented Feb 3, 2015

javiereguiluz commented Feb 3, 2015