Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to make symfony.phar executable. #4533

Closed
wants to merge 1 commit into from

Conversation

xelaris
Copy link
Contributor

@xelaris xelaris commented Nov 29, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@xabbuh
Copy link
Member

xabbuh commented Nov 29, 2014

👍 This really makes sense.

@weaverryan @wouterj Should be merged into 2.3.

@xabbuh
Copy link
Member

xabbuh commented Dec 4, 2014

@weaverryan @wouterj Can we merge this or #4558 in the short term? People are getting crazy about it. :)

weaverryan added a commit that referenced this pull request Dec 4, 2014
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #4533).

Discussion
----------

Add command to make symfony.phar executable.

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

dd9de4e Add command to make symfony.phar executable.
@weaverryan
Copy link
Member

Thanks @xabbuh for the ping and @xelaris for the PR!

I updated it further at sha: 4257a27 because (for better or worse) I want it to exactly match what we have on the README; https://github.com/symfony/symfony-installer/blob/master/README.md#linux-and-mac-os-x

@javiereguiluz We need to reduce the number of places we have the installation instructions ideally down to 1. That can be inside the documentation or on the new download page and then things should link to that one source. For the bet experience, what do you think? A downside of the download page is that we can't easily update it, but it shouldn't need too many updates over time (I'm talking about updates similar to this PR, as we find little bugs in the commands). Once nice side of the downloads page is that we can have a nicer interface for choosing between Unix and Windows, instead of having 2 bulky sections like we have in the docs. I would probably prefer the downloads page, now that I think about that :).

Thanks!

@weaverryan weaverryan closed this Dec 4, 2014
weaverryan added a commit that referenced this pull request Dec 4, 2014
* 2.3:
  Updating the installer docs to exactly match that repository's README - see #4533
  Add command to make symfony.phar executable.
  fixed little typo
weaverryan added a commit that referenced this pull request Dec 4, 2014
* 2.5:
  Updating the installer docs to exactly match that repository's README - see #4533
  Add command to make symfony.phar executable.
  fixed little typo
weaverryan added a commit that referenced this pull request Dec 4, 2014
* 2.7:
  Updating the installer docs to exactly match that repository's README - see #4533
  Add command to make symfony.phar executable.
  fixed little typo
@wouterj
Copy link
Member

wouterj commented Dec 6, 2014

Can't we include the installation page in symfony/symfony-marketing ? That would be the best option imo

@weaverryan
Copy link
Member

We probably couldn't make the whole page in symfony/symfony-marketing, but it might be possible to expose at least some of the text blocks there. And yea, that'd be pretty cool :).

@xelaris xelaris deleted the patch-1 branch October 31, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants