Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best Practices: Update link title to match cookbook article title #4529

Closed
wants to merge 2 commits into from

Conversation

dangarzon
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

Article title updated in c9fe05b

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | 

Article title updated in c9fe05b
@xabbuh
Copy link
Member

xabbuh commented Nov 29, 2014

Thank you for finding this @dangarzon.

However, it's actually not a good idea that we use absolute URL's to link from the best practices to the rest of the documentation. It seems that we didn't think about removing them when the best practices were imported into the documentation repository. What we should do is replacing all links to the best practices with doc roles or ref roles (whatever fits best in the context of a reference). @dangarzon Do you think you will be able to do that or should we open an issue for this?

@dangarzon
Copy link
Contributor Author

Ok,
I will take care!

@dangarzon
Copy link
Contributor Author

@xabbuh
Updated links in configuration article.

I'm working in the other articles of this book with @jms85, will keep the PRs going.

@wouterj
Copy link
Member

wouterj commented Nov 29, 2014

I love your work today, Daniel! Thanks.

wouterj added a commit that referenced this pull request Nov 29, 2014
…le title (dangarzon)

This PR was squashed before being merged into the 2.3 branch (closes #4529).

Discussion
----------

Best Practices: Update link title to match cookbook article title

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Article title updated in c9fe05b

Commits
-------

23db11a Best Practices: Update link title to match cookbook article title
@wouterj wouterj closed this Nov 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants