Updated autoload standard to PSR-4. #4255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phansys
commented
Sep 21, 2014
phansys
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New feature? | no |
| Applies to | 2.0+ |
| Tests pass? | yes |
| Fixed tickets | #3616 |
| Q | A | ------------- | --- | Doc fix? | no | New feature? | no | Applies to | 2.0+ | Tests pass? | yes | Fixed tickets | symfony#3616
|
-1, Symfony currently doesn't use PSR-4 afaik /cc @fabpot |
|
@wouterj technically, our codebase respects both PSR-0 and PSR-4, given that it is not impacted by the difference between them (we don't use underscores in class names). |
|
@fabpot what's your opinion on this? |
|
I think we should merge this PR. I've flagged it as Finished and @weaverryan will merge it sometime :) Thanks @phansys and sorry for the delay! |
|
Yep, I totally agree with merging this :). Thanks Javier! |
weaverryan
added a commit
that referenced
this pull request
May 22, 2015
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4255). Discussion ---------- Updated autoload standard to PSR-4. | Q | A | ------------- | --- | Doc fix? | no | New feature? | no | Applies to | 2.0+ | Tests pass? | yes | Fixed tickets | #3616 Commits ------- d9a2f61 Updated autoload standard to PSR-4.
|
Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.