Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix Console component getHelperSet()->get() to getHelper() #3993

Merged
merged 1 commit into from
Jul 11, 2014

Conversation

eko
Copy link
Contributor

@eko eko commented Jul 5, 2014

Q A
Doc fix? Yes
New docs? No
Applies to 2.3
Fixed tickets No

On Console component, I've fixed the following calls:

$this->getHelperSet()->get('dialog');

to:

$this->getHelper('dialog');

This is related to original PR #3952

@weaverryan
Copy link
Member

Yes, you've made my life easy :). Thanks Vincent!

@weaverryan weaverryan merged commit 9207f68 into symfony:2.3 Jul 11, 2014
weaverryan added a commit that referenced this pull request Jul 11, 2014
…getHelper() (eko)

This PR was merged into the 2.3 branch.

Discussion
----------

[Console] Fix Console component getHelperSet()->get() to getHelper()

| Q                  | A          |
| ---------------- |:---------:|
| Doc fix?        | Yes |
| New docs?   | No   |
| Applies to     | 2.3   |
| Fixed tickets | No   |

On Console component, I've fixed the following calls:

```php
$this->getHelperSet()->get('dialog');
```

to:

```php
$this->getHelper('dialog');
```

This is related to original PR #3952

Commits
-------

9207f68 [Console] Fix Console component getHelperSet()->get() to getHelper()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants