Fixed the section about getting services from a command #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| However for other services the solution might be more complex. You may even need | ||
| to manually create a ``request`` service and then call the ``enterScope('request')`` | ||
| and the ``set('request', $request)`` methods. |
There was a problem hiding this comment.
Let's remove this section and refer to the scopes article in the DI components docs for solutions to these more complex cases.
There was a problem hiding this comment.
I don't understand exactly what are you suggesting to remove? Do you suggest to remove all the contents introduced in this section?
There was a problem hiding this comment.
I meant this paragraph, sorry for being unclear about that
|
This is a really great explanation. Thanks Javier! |
weaverryan
added a commit
that referenced
this pull request
Jun 7, 2014
… (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Fixed the section about getting services from a command | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #890 Hopefully this PR fixes one of the oldest errors of the Symfony documentation. Commits ------- 8993beb Linked the cookbook about DIC scopes 0f3c218 Fixed the section about getting services from a command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this PR fixes one of the oldest errors of the Symfony documentation.