Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Front Controller #3871

Closed
wants to merge 1 commit into from
Closed

Fix missing Front Controller #3871

wants to merge 1 commit into from

Conversation

psgk
Copy link

@psgk psgk commented May 26, 2014

Added app_dev.php front controller to the demo url.

Added `app_dev.php` front controller to the demo url.
@wouterj
Copy link
Member

wouterj commented May 26, 2014

The Quick Tour guide assumes that you used the server:run command. When you do that, the app_dev.php part should be omitted from the URL. So this change is incorrect.

However, since you didn't knew this, do we have to clarify this a bit more in the quick tour? Or did you just skipped the "Running Symfony2" section?

@psgk
Copy link
Author

psgk commented May 26, 2014

Ok. That sounds good.
It's bit confusing when we are looking at each part of the URL and there is no mention of app_dev.php in the URL part. A quick note may help the readers.

@weaverryan
Copy link
Member

@wouterj Hmm, we do mention app_dev.php right below this actually, so there is a problem. Also, since putting app_dev.php in there still works, perhaps we should default and include this?

@wouterj
Copy link
Member

wouterj commented May 30, 2014

since putting app_dev.php in there still works, perhaps we should default and include this?

Does it?

@xabbuh
Copy link
Member

xabbuh commented May 31, 2014

Yes, it does. I just tried it out.

@wouterj
Copy link
Member

wouterj commented May 31, 2014

Ok, 👍 then! Thanks @xabbuh and @parthasarathigk !

@weaverryan
Copy link
Member

Great, thanks Parthasarathi for this bug fix!

weaverryan added a commit that referenced this pull request Jun 7, 2014
This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #3871).

Discussion
----------

Fix missing Front Controller

Added `app_dev.php` front controller to the demo url.

Commits
-------

f2df407 Fix missing Front Controller
@weaverryan weaverryan closed this Jun 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants