Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to recommend the built-in Serializer instead of JMSSerializer #5069

Closed
dunglas opened this issue Mar 9, 2015 · 3 comments
Closed

Update to recommend the built-in Serializer instead of JMSSerializer #5069

dunglas opened this issue Mar 9, 2015 · 3 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Serializer

Comments

@dunglas
Copy link
Member

dunglas commented Mar 9, 2015

Follows symfony/symfony#13875

@andreaslarssen The doc is in the process of being updated, see this PR for instance: https://github.com/symfony/symfony-docs/pull/4675/files

JMSSerializer still have advanced features (especially regarding XML support) that are unlikely to be added in the Symfony built-in Serializer. However, most of the "must have" features have been added to the built in component including groups support, circular references handling, property name converter, normalization of objects having both publics properties and getters / setters...

IMO, we can update the doc to explain how to use the built-in Serializer instead of recommending using JMS Serializer. Any help is welcome.
This was referenced Mar 11, 2015
Closed
Merged
@javiereguiluz
Copy link
Member

In #5074 I've removed the only explicit reference to JMS serializer that I've found in the documentation. And in #5075 I've removed a comment about a built-in serializer limitation which is no longer true for Symfony 2.6+.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Mar 11, 2015
@dunglas
Copy link
Member Author

dunglas commented Mar 11, 2015

Thank you @javiereguiluz!

@dunglas
Copy link
Member Author

dunglas commented Mar 11, 2015

Another related issue: #4698

weaverryan added a commit that referenced this issue Mar 14, 2015
@weaverryan
minor #5075 Removed an admonition that is no longer true for Symfony …
33232a8 
…2.6+ (javiereguiluz)

This PR was merged into the 2.6 branch.

Discussion
----------

Removed an admonition that is no longer true for Symfony 2.6+

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.6+
| Fixed tickets | #5069

In Symfony 2.6 and newer, circular references are no longer a problem, as explained in http://symfony.com/doc/current/components/serializer.html#handling-circular-references

Commits
-------

5b527ae Removed an admonition that is no longer true for Symfony 2.6+
@javiereguiluz javiereguiluz mentioned this issue Jun 23, 2015
Merged
weaverryan added a commit that referenced this issue Jul 12, 2015
@weaverryan
minor #5429 Promote Symfony's builtin serializer instead of JMS (javi…
2e9cfb9 
…ereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

Promote Symfony's builtin serializer instead of JMS

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #5069

Commits
-------

beac11e Use the built-in serializer instead of promoting JMS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Serializer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dunglas @javiereguiluz @weaverryan @xabbuh