-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Best Practices] weird link captions in cross references #4822
Comments
@dbu I agree that these cross references are pretty bad. Thanks for reporting it! I'll take care of fixing this issue. |
I always prefer to use quotes when referencing articles: However, I know @weaverryan isn't a big fan of this |
@wouterj At least, imho you example doesn't read really better. I would prefer to set the link text manually here. |
…ked wrong (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Add custom link labels where Cookbook articles titles looked wrong | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4822 Commits ------- 1b31ad1 Add custom link labels where Cookbook articles titles looked wrong
The best practices articles have many places where a cross reference uses the full title of a cookbook entry or doc chapter, making for weird grammar: "If you need to execute some code before or after the execution of your controllers, you can use the EventDispatcher component to How to Setup before and after Filters." for example, http://symfony.com/doc/2.3/best_practices/controllers.html#pre-and-post-hooks
almost every section has one of those links. not harmful, but a bit confusing.
The text was updated successfully, but these errors were encountered: