Check for null parent Nodes in the case of orphaned branches

symfony · Feb 14, 2025 · 19073e3 · 19073e3
1 parent fd07959
commit 19073e3
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/Crawler.php b/Crawler.php
@@ -431,7 +431,7 @@ public function closest(string $selector): ?self
 
         $domNode = $this->getNode(0);
 
-        while (\XML_ELEMENT_NODE === $domNode->nodeType) {
+        while (null !== $domNode && \XML_ELEMENT_NODE === $domNode->nodeType) {
             $node = $this->createSubCrawler($domNode);
             if ($node->matches($selector)) {
                 return $node;

diff --git a/Tests/AbstractCrawlerTestCase.php b/Tests/AbstractCrawlerTestCase.php
@@ -1031,6 +1031,29 @@ public function testClosest()
         $this->assertNull($notFound);
     }
 
+    public function testClosestWithOrphanedNode()
+    {
+        $html = <<<'HTML'
+<html lang="en">
+<body>
+    <div id="foo" class="newFoo ok">
+        <div class="lorem1 ko"></div>
+    </div>
+</body>
+</html>
+HTML;
+
+        $crawler = $this->createCrawler($this->getDoctype().$html);
+        $foo = $crawler->filter('#foo');
+
+        $fooNode = $foo->getNode(0);
+
+        $fooNode->parentNode->replaceChild($fooNode->ownerDocument->createElement('ol'), $fooNode);
+
+        $body = $foo->closest('body');
+        $this->assertNull($body);
+    }
+
     public function testOuterHtml()
     {
         $html = <<<'HTML'