Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker runtime follow up #234

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Docker runtime follow up #234

merged 5 commits into from
Jul 9, 2024

Conversation

Munsio
Copy link
Contributor

@Munsio Munsio commented Jul 2, 2024

No description provided.

@Munsio Munsio force-pushed the docker-runtime-follow-up branch 5 times, most recently from 186d74d to b9b3d2f Compare July 4, 2024 08:52
@Munsio Munsio marked this pull request as ready for review July 4, 2024 09:17
@Munsio Munsio requested review from bauersimon and ahumenberger July 4, 2024 09:18
@Munsio
Copy link
Contributor Author

Munsio commented Jul 4, 2024

Currently the CI job itself is flaky with some permission problems. I will investigate that one further but in the meantime the PR can be reviewed.

@Munsio Munsio force-pushed the docker-runtime-follow-up branch 8 times, most recently from ff3b196 to b15bac4 Compare July 4, 2024 14:50
@Munsio
Copy link
Contributor Author

Munsio commented Jul 4, 2024

We need to override the docker image with the tag from the current branch.
Also we need to run the tests after the image was created.

bauersimon
bauersimon previously requested changes Jul 8, 2024
View reviewed changes
cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate.go Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate.go Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate_test.go Outdated Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate_test.go Outdated Show resolved Hide resolved
@Munsio Munsio force-pushed the docker-runtime-follow-up branch 3 times, most recently from 09716ae to e548b5d Compare July 8, 2024 13:13
@Munsio Munsio self-assigned this Jul 8, 2024
@Munsio Munsio added this to the v0.6.0 milestone Jul 8, 2024
@Munsio Munsio force-pushed the docker-runtime-follow-up branch 6 times, most recently from f793c8c to 5be5dc3 Compare July 8, 2024 13:53
@Munsio Munsio force-pushed the docker-runtime-follow-up branch from 5dbd0d2 to 8defd7e Compare July 9, 2024 07:44
@Munsio
Copy link
Contributor Author

Munsio commented Jul 9, 2024

@bauersimon docker test runs through. Please review all again did some major reworking.

@Munsio Munsio requested a review from bauersimon July 9, 2024 09:16
bauersimon
bauersimon reviewed Jul 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
bauersimon
bauersimon reviewed Jul 9, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@Munsio Munsio force-pushed the docker-runtime-follow-up branch 7 times, most recently from 8fad6c9 to a1ad3a9 Compare July 9, 2024 10:36
@Munsio
Build the Docker image with a MultiStage build
f90a874 
By using a MultiStage build we avoid copying the whole evaluation repository into the Docker image.
Also fixed some creations of folders and permissions regarding non-docker run containers.
@Munsio Munsio force-pushed the docker-runtime-follow-up branch from 14ed973 to 7d2b8f6 Compare July 9, 2024 10:39
@Munsio Munsio force-pushed the docker-runtime-follow-up branch from 7d2b8f6 to ddd1e54 Compare July 9, 2024 10:45
@Munsio
Copy link
Contributor Author

Munsio commented Jul 9, 2024

I had to skip the docker runtime in local tests for now as we do have a problem with the "commit hashes" - I hope we can fix that with: #207

Docker runtime tests are skipped locally and only run inside the Github Actions CI

@bauersimon bauersimon merged commit c07ed10 into main Jul 9, 2024
4 checks passed
@bauersimon bauersimon deleted the docker-runtime-follow-up branch July 9, 2024 11:03
@Munsio Munsio mentioned this pull request Jul 9, 2024
Merged
@bauersimon bauersimon added the enhancement New feature or request label Jul 31, 2024
@bauersimon bauersimon mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bauersimon bauersimon bauersimon left review comments

@ahumenberger ahumenberger Awaiting requested review from ahumenberger

Assignees

@Munsio Munsio

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Munsio @bauersimon