Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker runtime #211

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Docker runtime #211

merged 3 commits into from
Jun 27, 2024

Conversation

Munsio
Copy link
Contributor

@Munsio Munsio commented Jun 24, 2024

No description provided.

@Munsio Munsio requested a review from bauersimon June 26, 2024 09:38
@Munsio
Copy link
Contributor Author

Munsio commented Jun 26, 2024

@bauersimon can you do a review + early merger?

@Munsio Munsio force-pushed the docker-runtime branch 6 times, most recently from d081a02 to 24e2e13 Compare June 26, 2024 10:01
@Munsio Munsio marked this pull request as ready for review June 26, 2024 10:01
cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved
util/exec.go Outdated Show resolved Hide resolved
util/exec_test.go Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate.go Outdated Show resolved Hide resolved
cmd/eval-dev-quality/cmd/evaluate.go Show resolved Hide resolved
@Munsio Munsio requested a review from ruiAzevedo19 June 27, 2024 08:24
@bauersimon bauersimon added the enhancement New feature or request label Jun 27, 2024
@bauersimon bauersimon added this to the v0.6.0 milestone Jun 27, 2024
util/exec.go Outdated Show resolved Hide resolved
…ions on the executing machine directly

Part of #198
@Munsio Munsio force-pushed the docker-runtime branch 2 times, most recently from 51784a1 to 28150f5 Compare June 27, 2024 12:41
Munsio added 2 commits June 27, 2024 15:01
… use for a different runtime

If none is specified we will always use the taged version defined within eval-dev-quality

Part of #198
@bauersimon bauersimon self-requested a review June 27, 2024 13:24
@bauersimon bauersimon merged commit 6fd5180 into main Jun 27, 2024
4 checks passed
@bauersimon bauersimon deleted the docker-runtime branch June 27, 2024 13:24
@bauersimon bauersimon mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants