-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if all testdata repositories are well-formed just once, and not in every task run #263
Comments
Would basically just extend the type Repository interface {
Validate() error
... and that way you can just call that function in the two locations you mentioned above right after creating the repository and internally you will probably do a switch based on the task identifiers that the repository has... and do one special validation function per task... would probably even leave the validation logic itself where the tasks are (i.e. |
so basically i would not do a function that knows how to validate all types of repository... I think it is still good that this logic is separated... but the way that the repository validation is invoked should just be via the |
…on, so it is checked just once Part of #263
… for the "write-tests" task is well-formed Part of #263
… for the "write-tests" task is well-formed Part of #263
…on, so it is checked just once Part of #263
… for the "write-tests" task is well-formed Part of #263
… for the "write-tests" task is well-formed Part of #263
…on, so it is checked just once Part of #263
… for the "write-tests" task is well-formed Part of #263
…on, so it is checked just once Part of #263
… for the "write-tests" task is well-formed Part of #263
…on, so it is checked just once Part of #263
… for the "write-tests" task is well-formed Part of #263
…on, so it is checked just once Part of #263
… for the "write-tests" task is well-formed Part of #263
…s into a helper, for reusability Part of #263
…rom a package into a helper, for reusability Part of #263
…g the evaluation, so it is checked just once Closes #263
…lidation tests, so cross-OS error check can be done Part of #263
…g the evaluation, so it is checked just once Closes #263
…s into a helper, for reusability Part of #263
…rom a package into a helper, for reusability Part of #263
…lidation tests, so cross-OS error check can be done Part of #263
…s into a helper, for reusability Part of #263
…rom a package into a helper, for reusability Part of #263
…lidation tests, so cross-OS error check can be done Part of #263
…g the evaluation, so it is checked just once Closes #263
Goal: check if the testdata repositories are well-formed just once and not in every run.
Currently, we check if a task repository is well-formed when we run the task itself. Since we can have multiple runs, we are checking the same thing over and over again. There needs to be an extra step before running all the tasks where we validate the testdata repositories.
TODO
Validate() error
evaluate/evaluate.go:Evaluate
plain
repository (after calculating thetemporaryRepositories
and before the evaluation loop)temporaryRepositories
and before the evaluation loop)The text was updated successfully, but these errors were encountered: