Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Ollama tests with the wrong Ollama binary should fail hard #156

Closed
zimmski opened this issue Jun 4, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@zimmski
Copy link
Member

zimmski commented Jun 4, 2024

I wasted some time to figure out that my Ollama binary was not up to date for the tests. Having a check for that in some "init" function that fails hard if the version is not correct would have made that perfectly clear.

@zimmski zimmski added the bug Something isn't working label Jun 4, 2024
@zimmski zimmski added this to the v0.6.0 milestone Jun 4, 2024
@bauersimon bauersimon self-assigned this Jun 10, 2024
@bauersimon
Copy link
Member

Just had the same thing happen with Symflower. The only problem is that there is no "global" init function, and tests are run per package. I.e. if we put the version check into one init function (i.e. maybe within the tools package) then still all other i.e. evaluate tests would fail with cryptic error messages... So instead we have to check for ever test that that needs a tool... I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants