deps: switch to runc/libcontainer/cgroups cgroup manager #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Switch our cgroups management dependency from
containerd/cgroups
toopencontainers/runc/libcontainer/cgroups
in order to ease implementation of systemd / unprivileged delegation etc.This is the first step of the process of tidying up the cgroups manager code. At this point I have chosen to:
cgroups.Manager
interface with a newcgroups.ManagerLC
inmanager_libcontainer_linux.go
. This avoids code changes in the runtime for this initial swap-out.containerd/cgroups
basedcgroups.ManagerV1
andcgroups.ManagerV2
.ManagerV1
andManagerV2
and point them toManagerLC
.The purpose of this approach is to first be happy that there's no impact from switching the dep out.
Refactoring will occur to address the facts that:
New/Set/Apply
cycle.Testing
The PR tests against cgroups v1 in CI (Ubuntu 20.04).
I have been testing locally against cgroups v2 unified on Fedora 35.
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make check
and tested this PR locally with amake test
, andmake testall
if possible (see CONTRIBUTING.md).