oci: cgroupsv2 namespace / mount handling #3542
Merged
+94
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OCI-Mode, try to create a cgroup for the container even when no resource limits have been requested. On a cgroups v2 system, with functioning cgroups management, create a cgroups namespace for OCI-Mode containers, and perform an explicit `/sys/fs/cgroups` mount. The mount is `ro` by default, or `rw` when `--keep-privs` is specified. This fixes issues with nested container execution in OCI-Mode, and improves compatibility with other OCI runtimes. Fixes sylabs#3538
wobito
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
In OCI-Mode, try to create a cgroup for the container even when no resource limits have been requested.
On a cgroups v2 system, with functioning cgroups management, create a cgroups namespace for OCI-Mode containers, and perform an explicit
/sys/fs/cgroupsmount. The mount isroby default, orrwwhen--keep-privsis specified.This fixes issues with nested container execution in OCI-Mode, and improves compatibility with other OCI runtimes.
Verified manually on cgroups v2 (Fedora/Ubuntu 24.04) and checked for regression on cgroups v1 (RHEL8).
This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).