fix: cgroups: check for systemd init when needed #3537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
force-pushed
the
issue-3536
branch
3 times, most recently
from
6a10bf8 to
bc50829
Compare
dtrudg
changed the title
When `CanUseCgroups` is called, with systemd as the intended cgroups manager, make sure that a systemd init is actually running. This fixes flows where Singularity run nested inside another container, that doesn't provide a systemd init or mount the host `/run` directory into the container. Fixes sylabs#3536
wobito
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
When
CanUseCgroupsis called, with systemd as the intended cgroups manager, make sure that a systemd init is actually running.This fixes flows where Singularity run nested inside another container, that doesn't provide a systemd init or mount the host
/rundirectory into the container.This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).