chore: swap deprecated tenv linter for usetesting #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usetesting linter shows a lot of lint on e2e code for tempdir handling. The e2e-tests are written, and have helper functions, designed around keeping temp directories inside a single per-run outer directory, often with somewhat useful naming. This would be broken by a switch to t.TempDir. The usetesting linter shows a lot of lint on e2e code for env var handling. It's not often simple to switch to t.Setenv - the scope of env vars is more complex due to the e2e.Singularitycmd construct etc.
dtrudg
force-pushed
the
additional-linter-swaps
branch
from
580da7c to
9314d86
Compare
wobito
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap the deprecated
tenvlinter forusetesting, and fix lint excludinge2e/files.The e2e test code is excluded as:
The usetesting linter shows a lot of lint on e2e code for tempdir handling. The e2e-tests are written, and have helper functions, designed around keeping temp directories inside a single per-run outer directory, often with somewhat useful naming. This would be broken by a switch to t.TempDir.
The usetesting linter shows a lot of lint on e2e code for env var handling. It's not often simple to switch to t.Setenv - the scope of env vars is more complex due to the e2e.Singularitycmd construct etc.