Skip to content

Enable unified cgroups spec & test #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtrudg opened this issue Feb 1, 2022 · 0 comments · Fixed by #539
Closed

Enable unified cgroups spec & test #538

dtrudg opened this issue Feb 1, 2022 · 0 comments · Fixed by #539
Assignees
@dtrudg
Labels
enhancement New feature or request
Milestone
SingularityCE 3.10

Comments

@dtrudg
Copy link
Member

dtrudg commented Feb 1, 2022

With #530 in place, we are now using underlying cgroups code that supports the unified key in specs-go LinuxResources.

Allow SingularityCE to accept unified cgroups resource specs, and test this functionality.
@dtrudg dtrudg added the enhancement New feature or request label Feb 1, 2022
@dtrudg dtrudg added this to the SingularityCE 3.10 milestone Feb 1, 2022
@dtrudg dtrudg self-assigned this Feb 1, 2022
dtrudg added a commit to dtrudg/singularity that referenced this issue Feb 1, 2022
@dtrudg
feat: enable native v2 unified cgroups config
82f1d55 
Allow the `unified` key to be uses in a cgroups config toml file, to
directly apply resources limits using the v2 unified hierarchy, rather
than v1 -> v2 translation.

Fixes: sylabs#538
dtrudg added a commit to dtrudg/singularity that referenced this issue Feb 1, 2022
@dtrudg
feat: enable native v2 unified cgroups config
43c8226 
Allow the `unified` key to be used in a cgroups config toml file, to
directly apply resource limits using the v2 unified hierarchy, rather
than v1 -> v2 translation.

Fixes: sylabs#538
@dtrudg dtrudg mentioned this issue Feb 1, 2022
Merged
edytuk pushed a commit to vzokay/apptainer that referenced this issue Mar 16, 2022
@dtrudg @edytuk
feat: enable native v2 unified cgroups config
7b8ff23 
Allow the `unified` key to be used in a cgroups config toml file, to
directly apply resource limits using the v2 unified hierarchy, rather
than v1 -> v2 translation.

Fixes: sylabs/singularity#538
Signed-off-by: Edita Kizinevic <[email protected]>
This was referenced Mar 16, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtrudg dtrudg

Labels
enhancement New feature or request
Projects
None yet
Milestone
SingularityCE 3.10
Development

Successfully merging a pull request may close this issue.

feat: enable native v2 unified cgroups config dtrudg/singularity
1 participant
@dtrudg