Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update latex layer to track new AUCTeX naming conventions #16283

Closed
wants to merge 1 commit into from

Conversation

dankessler
Copy link
Contributor

AUCTeX has changed its naming conventions, e.g., latex-mode is now LaTeX-mode. In order to support both users of the "new" AUCTeX and the "old" AUCTeX, I've configured the keybinding part of the latex layer to configure both old and new version of these modes.

See #16282 for more discussion.

@arifer612
Copy link
Contributor

Tested out the proposed changes and it works great on lsp v20240215.1823. The
changes are backwards compatible too (b^-^)b

@dankessler dankessler marked this pull request as draft February 16, 2024 19:58
@dankessler
Copy link
Contributor Author

I just noticed that my PR doesn't fix all the latex-related keybinds, e.g., I missed fixing the way reftex keys are bound (which are still only available in actual latex-mode).

I've marked the PR as a draft so I can fix this, re-push, and then I'll mark ready for review.

Rather than littering latex's packages.el file with every more dolists and code duplication, I'm just going to add some logic at the top that figures out whether latex-mode or LaTeX-mode is appropriate, sets some private variables, and then uses those throughout. Hopefully that will still give backwards compatibility while reducing code bloat.

@dankessler
Copy link
Contributor Author

Upon further reflection, I think this is better fixed upstream in bind-map. I've opened a PR there that should fix (the keybinds part of) #16282 without requiring this PR. I'm going to leave this PR in draft status for now, and if the PR against bind-map is adopted we can scrub it. If the fix can't go into bind-map, then we can revisit a workaround based on this PR.

@dankessler
Copy link
Contributor Author

This has been fixed (I think?) upstream now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants