Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete TodoMVC spec conforming implementation #60

Merged
merged 15 commits into from
Mar 26, 2021
Merged

Complete TodoMVC spec conforming implementation #60

merged 15 commits into from
Mar 26, 2021

Conversation

lukechu10
Copy link
Member

@lukechu10 lukechu10 commented Mar 25, 2021

This PR also includes some bug fixes and QOL improvements discovered while implementing TodoMVC:

  • Implement std::fmt::Debug for Signal and StateHandle
  • Parse keywords in component path
  • Fix parsing of a component followed immediately by an interpolated value
    The following code previously failed to parse:
    template! {
        div {
            MyComponent()
            (interpolated_value)
        }
    }
    because the interpolated value would be treated as a function call of the previous component.
  • Add an untrack utility for creating an untracked scope. This is useful when for example, calling a passed in closure and not wanting it to subscribe to current reactive scope.
  • Create components inside an untracked scope (fixes tracking bugs when using template! inside interpolated values).
  • Implement PartialEq for Signal and StateHandle.
  • Implement Serialize and Deserialize for Signal and StateHandle only when the serde feature is enabled.

@lukechu10 lukechu10 added A-examples Area: examples C-bug Category: bug, something isn't working labels Mar 26, 2021
@lukechu10 lukechu10 marked this pull request as ready for review March 26, 2021 04:29
@lukechu10 lukechu10 merged commit 8eda5aa into master Mar 26, 2021
@lukechu10 lukechu10 deleted the todomvc branch March 26, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples Area: examples C-bug Category: bug, something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant