-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline props #486
Merged
Merged
Inline props #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
==========================================
+ Coverage 64.48% 64.87% +0.39%
==========================================
Files 52 52
Lines 8399 8481 +82
==========================================
+ Hits 5416 5502 +86
+ Misses 2983 2979 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Benchmark Report
@@ Performance Diff @@
## | wasm-bindgen | baseline | update | diff ##
##########################################################################
01_run1k | 114.95 | 0.00 | 0.00 | NaN%
02_replace1k | 119.60 | 0.00 | 0.00 | NaN%
03_update10th1k_x16 | 407.24 | 0.00 | 0.00 | NaN%
04_select1k | 58.59 | 0.00 | 0.00 | NaN%
05_swap1k | 96.99 | 0.00 | 0.00 | NaN%
06_remove-one-1k | 30.36 | 0.00 | 0.00 | NaN%
07_create10k | 1224.32 | 0.00 | 0.00 | NaN%
08_create1k-after1k_x2 | 278.96 | 0.00 | 0.00 | NaN%
09_clear1k_x8 | 78.74 | 0.00 | 0.00 | NaN%
21_ready-memory | 2.14 | 0.00 | 0.00 | NaN%
22_run-memory | 3.52 | 0.00 | 0.00 | NaN%
23_update5-memory | 3.62 | 0.00 | 0.00 | NaN%
25_run-clear-memory | 2.19 | 0.00 | 0.00 | NaN%
26_run-10k-memory | 17.06 | 0.00 | 0.00 | NaN%
31_startup-ci | 1782.63 | 0.00 | 0.00 | NaN%
32_startup-bt | 0.00 | 0.00 | 0.00 | NaN%
33_startup-mainthreadcost | 20.40 | 0.00 | 0.00 | NaN%
34_startup-totalbytes | 189.33 | 0.00 | 0.00 | NaN% Workflow: 3082008700 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements inline props. This makes it possible to create a component accepting props without creating an extra
struct
just for the props.The adopted syntax is
#[component(inline_props)]
.See new section in book for more details.