-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document improvement #451
Document improvement #451
Conversation
@danielalvsaaker I have applied you changes. |
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
=======================================
Coverage 64.51% 64.51%
=======================================
Files 52 52
Lines 8409 8407 -2
=======================================
- Hits 5425 5424 -1
+ Misses 2984 2983 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left a bit of feedback here and there.
@lukechu10 applied the suggested changes. |
I just realized you made the changes to the 0.8 docs. Do you mind also making the to |
@lukechu10 done. Left the v0.8 additions because they are also valid for that version right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long. I noticed a small issue with the indentation, but I didn't want to delay this PR further, so I took the liberty of committing it myself (hopefully that's okay with you).
Indentation should be 4 spaces like normal Rust code.
During my initial start with the project I had com confusion about the items I have improved in this PR.
Please let me know if changes are needed.