Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document improvement #451

Merged
merged 8 commits into from
Jul 15, 2022
Merged

Conversation

johansmitsnl
Copy link
Contributor

During my initial start with the project I had com confusion about the items I have improved in this PR.

Please let me know if changes are needed.

@johansmitsnl
Copy link
Contributor Author

@danielalvsaaker I have applied you changes.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #451 (ba09ee3) into master (62f63c4) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ba09ee3 differs from pull request most recent head 0e264f1. Consider uploading reports for the commit 0e264f1 to get more accurate results

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   64.51%   64.51%           
=======================================
  Files          52       52           
  Lines        8409     8407    -2     
=======================================
- Hits         5425     5424    -1     
+ Misses       2984     2983    -1     
Impacted Files Coverage Δ
packages/sycamore-reactive/src/lib.rs 94.36% <0.00%> (-0.02%) ⬇️
website/src/main.rs 0.57% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f63c4...0e264f1. Read the comment docs.

Copy link
Member

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a bit of feedback here and there.

@johansmitsnl
Copy link
Contributor Author

@lukechu10 applied the suggested changes.

@johansmitsnl johansmitsnl requested a review from lukechu10 July 11, 2022 07:09
@lukechu10
Copy link
Member

lukechu10 commented Jul 11, 2022

I just realized you made the changes to the 0.8 docs. Do you mind also making the to docs/next? You can still leave the changes in 0.8 if it's too much trouble to remove them.
Otherwise, everything looks good.

@johansmitsnl
Copy link
Contributor Author

@lukechu10 done. Left the v0.8 additions because they are also valid for that version right?

Copy link
Member

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long. I noticed a small issue with the indentation, but I didn't want to delay this PR further, so I took the liberty of committing it myself (hopefully that's okay with you).

Indentation should be 4 spaces like normal Rust code.
@lukechu10 lukechu10 merged commit 167d3e1 into sycamore-rs:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants