Update boolean attributes in the view macro #440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some attributes but mostly removes attributes which are not
part of the standard.
I have gone through each attribute removed in this list just to make sure I'm
not removing something often used but not in the WHATWG standard for some
reason - this was never the case.
I can, if you like, explicitly list each removed attribute and link to some evidence
that it is either (1) not a boolean attribute (like
contenteditable
); (2) deprecated(like
scoped
); or (3) is not going to be implemented (likesortable
).As is this PR would be in sync with the boolean attributes listed in the WHATWG
attributes table.
This wouldn't prevent a user from using one of the removed attributes as a boolean
attribute in the case they are targeting some old version of a browser. They can
use the attribute name and set the value to either "" or to an empty
string but to remove it would probably need
NodeRef
and manually calling toremove the attribute.