Add the http-request-builder example #418
Conversation
This adds the same example as the http-request but using the builder syntax. Most of the code is the same and a fair degree of the change from macro to builder syntax is trivial. Using `Suspense` with the builder syntax is not covered in the documentation. This also shows off that structs that derive `Prop` have public builders which may be required using the builder syntax - such as with `SuspenseProps`.
There was a problem hiding this comment.
I do in fact plan to change some details about the builder API but I'm happy to merge this PR now because it might be a while before I actually do anything. Just one small comment, could you please add an entry to examples/README.md describing the example? Otherwise, LGTM
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 64.48% 64.48%
=======================================
Files 49 49
Lines 7958 7958
=======================================
Hits 5132 5132
Misses 2826 2826 Continue to review full report at Codecov.
|
Oh forgot to do that :) |
Make title more consistent with other examples
|
Thanks a lot. I just noticed a small nit in the index.html title but I changed it for you since I didn't want to bother you with such a small change. |
This adds the same example as the
http-requestbut using the buildersyntax.
Most of the code is the same and a fair degree of the change from macro
to builder syntax is trivial. Using
Suspensewith the builder syntaxdoes not seem to be covered in the documentation. This also shows off that structs
that derive
Prophave public builders which may be required using thebuilder syntax - such as with
SuspenseProps.I added a comment to the
SuspensePropspart just because I don't think it is obviousor documented (on the website) that by deriving
Propyou get a free typed builder too :)I know @lukechu10 spoke about changing the API around Suspense in the builder
syntax on Discord - so I'm aware you might have reason to not accept this PR yet (or at all) if
those changes are coming soon.
Closes #395