-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract sycamore
crate into multiple crates
#416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
- Coverage 64.97% 64.95% -0.03%
==========================================
Files 49 52 +3
Lines 8080 8289 +209
==========================================
+ Hits 5250 5384 +134
- Misses 2830 2905 +75
Continue to review full report at Codecov.
|
This comment was marked as resolved.
This comment was marked as resolved.
This is a BREAKING CHANGE
Merged
This comment was marked as resolved.
This comment was marked as resolved.
Benchmark Report
@@ Performance Diff @@
## | wasm-bindgen | baseline | update | diff ##
##########################################################################
+ 01_run1k | 164.34 | 217.27 | 209.24 | -3.69%
+ 02_replace1k | 174.51 | 229.27 | 221.38 | -3.44%
+ 03_update10th1k_x16 | 410.64 | 446.42 | 401.27 | -10.11%
04_select1k | 45.79 | 67.83 | 69.22 | +2.04%
05_swap1k | 101.45 | 101.10 | 99.51 | -1.58%
06_remove-one-1k | 34.79 | 37.88 | 37.43 | -1.17%
+ 07_create10k | 2058.07 | 2971.82 | 2809.54 | -5.46%
08_create1k-after1k_x2 | 427.35 | 498.49 | 491.65 | -1.37%
+ 09_clear1k_x8 | 111.90 | 152.18 | 139.93 | -8.05%
21_ready-memory | 1.47 | 1.44 | 1.44 | -0.05%
+ 22_run-memory | 1.35 | 1.68 | 1.62 | -3.67%
23_update5-memory | 1.35 | 1.65 | 1.64 | -0.27%
24_run5-memory | 1.68 | 1.85 | 1.85 | +0.11%
25_run-clear-memory | 1.41 | 1.28 | 1.27 | -0.53%
31_startup-ci | 1862.63 | 2032.30 | 2032.73 | +0.02%
32_startup-bt | 21.31 | 47.28 | 47.18 | -0.23%
- 33_startup-mainthreadcost | 331.44 | 345.56 | 380.91 | +10.23%
34_startup-totalbytes | 189.16 | 283.39 | 282.46 | -0.33% Workflow: 2335454036 |
mc1098
pushed a commit
to mc1098/sycamore
that referenced
this pull request
May 22, 2022
The builder feature flag was removed in sycamore-rs#416 but the website still contained a sentence about adding the feature flag before using the builder syntax.
lukechu10
pushed a commit
that referenced
this pull request
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New crates include:
sycamore-core
for core Sycamore functionality. This crate should provide backend-agnostic APIs. The web backend should also be included by default as that is by-far the most common use case for sycamore (at least for now).sycamore-web
that adds a few web specific APIs and the web backend.The
sycamore
crate should always re-exportsycamore-core
and re-exportsycamore-web
when a"web"
feature is enabled (should it be enabled by default?)This also updates the builder API to use free functions (i.e.
div()
instead ofh(div)
) and decouples it from html backends.The builder API is also included by default and the
builder
feature is removed.